384852 - Strict warning "does not always return a value" should only be shown once per function

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> (function(s,t) { if(s) return; if(t) return 1; return 2; }) 

 strict warning: anonymous function does not always return a value:
 strict warning: (function(s,t) { if(s) return; if(t) return 1; return 2; }) 
 strict warning: .............................................^
 strict warning: anonymous function does not always return a value:
 strict warning: (function(s,t) { if(s) return; if(t) return 1; return 2; }) 
 strict warning: .......................................................^

One of these warnings would be sufficient; there's no reason to warn every time another return statement is encountered.

It would be nice if it were more clear what the warning is complaining about.  Pointing to the return that *doesn't* include a value would be an improvement.

Comment 1

[André Bargull [:anba]]

Strict warning "does not always return a value" was removed in http://hg.mozilla.org/mozilla-central/rev/a470d0cbe3fa (bug 1046964)