Closed Bug 384873 Opened 15 years ago Closed 15 years ago

Broken building without XUL but with RDF

Categories

(Toolkit Graveyard :: Build Config, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file)

Attached patch BUILDFIXSplinter Review
libxul-config.mk:

....
ifdef MOZ_RDF
ifdef MOZ_XPFE_COMPONENTS                                                                                                                                                                           
 COMPONENT_LIBS += fileview                                                                                                                                                                          
 DEFINES += -DMOZ_FILEVIEW
....

is wrong because -DMOZ_FILEVIEW dependent only from MOZ_XUL

Also MOZ_XUL ifdef in nsStaticXULComponents.cpp required
Attachment #268776 - Flags: review?(benjamin)
Comment on attachment 268776 [details] [diff] [review]
BUILDFIX

Why you would want to build in this configuration is beyond me, but ok.
Attachment #268776 - Flags: review?(benjamin) → review+
What I have to do to check in this patch?
Same for other bug with RDF build define?

Whiteboard: [checkin-needed]
Whiteboard: [checkin-needed] → [checkin needed]
rdf is required by extension manager. for insane reasons someone is still trying to avoid xul while adding just about every other part of firefox. when it's over, xul will be there too, in the interim it's amusing to waste man months trying to make correct minimal configurations usable by someone else.
(In reply to comment #3)
> when
> it's over, xul will be there too,
Yes
> in the interim it's amusing to waste man
> months trying to make correct minimal configurations usable by someone else.

In the world exists not only Xeon Desktops and Laptops with big hard drive space and big memory...

There are also phones, multimedia boxes, terminals... 

I think there are nothing wrong if Gecko will be flexible in configuration and will be possible to build small gecko medium and full without 'bad words', and other problems...



Assignee: nobody → romaxa
Checking in toolkit/library/libxul-config.mk;
new revision: 1.45; previous revision: 1.44
Checking in toolkit/library/nsStaticXULComponents.cpp;
new revision: 1.48; previous revision: 1.47
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9beta1
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.