Closed
Bug 384874
Opened 18 years ago
Closed 18 years ago
Each element within grid|columns creates a new column
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: daniel, Assigned: neil)
References
Details
(Keywords: testcase)
Attachments
(2 files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.9a6pre) Gecko/20070617
In th latest XULRunner builds each element within a grid's "columns" element creates it's own column. In previous version one could place a spacer or a splitter between column elements and only column elements created a column.
see also bug 376246 for the history of this bug
Reproducible: Always
Reporter | ||
Comment 1•18 years ago
|
||
The testcase shows two grid elements each with two columns and a splitter in between.
The first assumes, that the two column elements result in two columns beeing created, so each row defines two child elements. This is how it was done in previous versions.
The second grid creates as many child elements for the row as are child elements in the columns element. Now the last column with the button is visible again.
Assignee | ||
Comment 2•18 years ago
|
||
I think this fixes things. Previously I matched the list lengths by making nsSprocketLayout::Layout skip the grid children for bogus columns, which turned out to be incorrect! This patch reverts that bogus change and instead makes both nsGridRowLeafLayout::PopulateBoxSizes and nsSprocketLayout::PopulateBoxSizes not consume grid children for bogus columns.
Assignee: nobody → neil
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #268789 -
Flags: review?(enndeakin)
Attachment #268789 -
Flags: review?(bzbarsky)
Comment 3•18 years ago
|
||
Comment on attachment 268789 [details] [diff] [review]
I think this fixes it
Seems ok.
Attachment #268789 -
Flags: review?(bzbarsky) → review+
Updated•18 years ago
|
Attachment #268789 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 4•18 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Flags: in-testsuite?
Reporter | ||
Comment 5•18 years ago
|
||
Good work Neil. Works again with the latest XULRunner nightly. Thanks
You need to log in
before you can comment on or make changes to this bug.
Description
•