Closed Bug 38492 Opened 25 years ago Closed 25 years ago

No vertical space around quote in plain text

Categories

(Core :: DOM: Serializers, defect, P3)

Product:
Core
Component:
DOM: Serializers
Type:
defect

Tracking

()

Status:
VERIFIED DUPLICATE of bug 46306

People

(Reporter: BenB, Assigned: akkzilla)

Details

Reproduce: - Reply to a msg in the HTML composer - Type something [ Optinally: - Set cursor inside quote - Press return - Type something ] - Debug|OutputText or send as plain text Actual result: - In the HTML composer, there's some vertical space shown between the blockquote and the normal text. This is as expected, because a normal HTML mail reader would display this msg sent as HTML in that way, too. - In the text output, there's no empty line between the quote and normal text. It looks messy. Expected result: Kind-of WYSIWYG: The vertical space roughly matches in all of - the display in the composer - the HTML output (even if read in a non-Mozilla-reader). - the text output I suggest to insert an empty line before and after the blockquote in the text output. However, this removes the ability to place text directly before/after the quote (e.g. the attribution line or a "[...]"). Does somebody else have a better idea?
I'll try to look at this tomorrow, but I assume it's related to the changes Joe just made in plaintext quoting. We were inserting a bunch of bogus whitespace, which we aren't inserting any more. Mail may need to insert newlines explicitly now, or something (which would be better than the previous situation, where there was no choice as to how much whitespace got inserted).
Status: NEW → ASSIGNED
The real issue here is how much the text output from an html stream should strive to look like the renddered html. There is a limit to how much work makes sense here. For instance, we could make the text output emit blank lines to mimic vertical margins around blockquotes, but it's probably not reasonable to look at every element for style attribute margin settings. Given that, someone could make a blockquote element with no margins, and then we would end up putting margins in on the text output. (Just a perverse example for your amusement.)
> However, this removes the ability to place text directly before/after the > quote Hm, maybe, this is just a case, where (plain 'ol) HTML and plain text don't mix well. I'd like to be proved wrong here, though. > I assume it's related to the changes Joe just made in plaintext quoting This bug has been around for what-do-I-know when. It is related in that sense, that my testing of his changes motivated me to actually file the bug now :). > Just a perverse example Not at all. Laugh, if you want, but I'm missing CSS support in the HTML->TXT converter.
Well, maybe we should look for margin style in the html to text conversion... The general point is, that there are limits to how far you can go, trying to make text output look like rendered html. But I dont pretend to know where the best place to draw the line is. If margin support isnt too hard, then perhaps we should add it.
Target Milestone: --- → M17
setting milestone to m17
There's a related bug: Reproduction: 1. Send yourself a HTML mail with the following content: 0 bla <p>bla</p> <blockquote type="cite">1 bla<p>bla</p><blockquote type="cite">2 bla<p>bla</p><blockquote type="cite">3 blabla<p>blablab</p><p>bla</p></blockquote>2 bla<p>bla</p></blockquote>1 bla <p>bla</p></blockquote> 0 bla<br> bla 2. Reply to it 3. Debug|OutputText Actual result: > 0 bla > > bla > >> 1 bla >> >> bla >> >>> 2 bla >>> >>> bla >>> >>>> 3 blabla >>>> >>>> blablab >>>> >>>> bla >>>> >>> 2 bla >>> >>> bla >>> >> 1 bla >> >> bla >> > 0 bla > bla Expected result: > 0 bla > > bla > >> 1 bla >> >> bla >> >>> 2 bla >>> >>> bla >>> >>>> 3 blabla >>>> >>>> blablab >>>> >>>> bla >>> >>> 2 bla >>> >>> bla >> >> 1 bla >> >> bla > > 0 bla > bla
Things have changed a bit, and I think this bug is now superceded by 46306. Ben, do you agree? *** This bug has been marked as a duplicate of 46306 ***
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
dunno, how they changed. QA: Please verify only, if the issues raised in the bug are fixed.
verified in 7/25 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.