385067 - Upgrade to latest version of sqlite

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Shawn Wilsher :sdwilsh]

We couldn't go to the very lastest version with Bug 341137.  This bug will have other dependencies.

Comment 1

[Shawn Wilsher :sdwilsh]

The current version (3.4.0) has some security stuff dealing with the upper bounds of data types.  See the change log for more details:
http://www.sqlite.org/changes.html#version_3_4_0

Comment 2

[Shawn Wilsher :sdwilsh]

Please note Bug 387609 Comment 2

Comment 3

[Shawn Wilsher :sdwilsh]

I'm having issues after updating my tree, but I'm pretty sure this works.  If anyone has any spare cycles to test non-mac platforms, it's be greatly appreciated.

http://files.shawnwilsher.com/2007/7/25/385067.patch

Comment 4

[Shawn Wilsher :sdwilsh]

That patch works for me with the patch to the testcase in Bug 387609.  I guess I need to get review on this or at least rs...

Comment 5

[Shawn Wilsher :sdwilsh]

Seth, can I get review on this?  Schrep said someone should take a look at it and since you've been the one reviewing storage changes anyway...

Comment 6

[(not reading, please use [e-mail] instead)]

testing this patch and the patch in bug #387609 on windows xp.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

FWIW, I've been running with this patch applied for the last few days with XPSP2 and it's been working fine for me thus far.

Comment 8

[(not reading, please use [e-mail] instead)]

Ryan, thanks for the data point.

I've also applied this patch and the one in bug #387609 on Windows XP SP2.

The following unit tests pass:

mozilla/toolkit/components/places/tests
mozilla/storage/test 
mozilla/toolkit/components/downloads/test

no problems with firefox with this upgrade so far, so rs=sspitzer on the upgrade.

Comment 9

[(not reading, please use [e-mail] instead)]

fix landed on shawn's behalf.

Checking in db/sqlite3/src/sqlite3.c;
/cvsroot/mozilla/db/sqlite3/src/sqlite3.c,v  <--  sqlite3.c
new revision: 1.6; previous revision: 1.5
done
Checking in db/sqlite3/src/sqlite3.h;
/cvsroot/mozilla/db/sqlite3/src/sqlite3.h,v  <--  sqlite3.h
new revision: 1.11; previous revision: 1.10
done

note, I also landed a note to README.MOZILLA:

Checking in db/sqlite3/README.MOZILLA;
/cvsroot/mozilla/db/sqlite3/README.MOZILLA,v  <--  README.MOZILLA
new revision: 1.11; previous revision: 1.10
done

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: MOZILLA.README change

Comment 11

[Shawn Wilsher :sdwilsh]

Comment on attachment 274939 [details] [diff] [review]
MOZILLA.README change

Looks good to me.  I seem to always forget about that...

Not sure we need the extra bit, but it won't hurt.

Comment 12

[(not reading, please use [e-mail] instead)]

oops, we went to 3.4.1, not 3.4.0, so I've updated the readme.

cvs ci db/sqlite3/README.MOZILLA
Checking in db/sqlite3/README.MOZILLA;
/cvsroot/mozilla/db/sqlite3/README.MOZILLA,v  <--  README.MOZILLA
new revision: 1.12; previous revision: 1.11
done