385118 - "ASSERTION: LoadObject was reentered?" after trying to "call" a flash object while it's out of the document

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jesse Ruderman]

Loading the testcase triggers:

###!!! ASSERTION: LoadObject was reentered?: '!mInstantiating', file /Users/jruderman/trunk/mozilla/content/base/src/nsObjectLoadingContent.cpp, line 694

(What does it mean to "call" a Flash object, anyway?)

Comment 1

[Jesse Ruderman]

Attachment: testcase

This testcase refers to the Flash object attached to bug 371878.  I think any Flash object would work, but that one isn't going to go away :)

Comment 2

[Johnny Stenback (:jst)]

Not a blocker based on the info available, but biesi, please do have a look at this one.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: oops

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 272886 [details] [diff] [review]
oops

r+sr=jst (bz, feel free to still look at this if you want to). I guess you could also move the setting of mInstantiating to true below this code, as there's nothing before here that cares whether it's set or not. Either way works for me.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Looks good to me too.  r=bzbarsky

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Notify() ends up creating the object frame, which ends up calling HasNewFrame, which looks at mInstantiating - that is, if I remember the code flow here correctly.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/base/src/nsObjectLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.cpp,v  <--  nsObjectLoadingContent.cpp
new revision: 1.50; previous revision: 1.49
done

the bug seems to cause the flash object not show up, so setting in-testsuite?