Closed
Bug 385221
Opened 17 years ago
Closed 17 years ago
use 10.4 SDK on all tinderboxes and GCC 4 on PPC
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(2 files, 1 obsolete file)
4.77 KB,
patch
|
mark
:
review+
ted
:
superreview+
|
Details | Diff | Splinter Review |
1.65 KB,
patch
|
mark
:
superreview+
|
Details | Diff | Splinter Review |
We need to update build stuff to get all tinderboxes using the 10.4u SDK and GCC 4 on PPC.
Comment 1•17 years ago
|
||
The tinderboxes should already have the correct SDKs, right? So this is as simple as updating http://mxr.mozilla.org/mozilla/source/build/macosx/universal/mozconfig with the correct SDK paths and GCC info?
This does the minimum we need to do to get everything using 10.4u and GCC 4 for PPC.
Attachment #269110 -
Flags: review?(mark)
Comment 3•17 years ago
|
||
Comment on attachment 269110 [details] [diff] [review] fix v1.0 case "${target_cpu}" in powerpc*) - dnl Architecture minimum 10.3 - dnl export MACOSX_DEPLOYMENT_TARGET=10.3 - export MACOSX_DEPLOYMENT_TARGET=10.2 + dnl Architecture minimum 10.4 + dnl export MACOSX_DEPLOYMENT_TARGET=10.4 + export MACOSX_DEPLOYMENT_TARGET=10.4 This doesn't need to be in a switch anymore, since you get 10.4 on any platform. Also, this string: + [ --enable-macos-target=VER (default=10.4/ppc, 10.4/x86) no longer needs to separate x86 and ppc. - GCC_VERSION=4.0 We should still leave GCC_VERSION set, just always to 4.0 without any conditional, because the rest of the config uses it. If you want to just use the system default compiler (gcc_select) always, additional changes will be needed.
Attachment #269110 -
Flags: review?(mark) → review+
Attachment #269110 -
Attachment is obsolete: true
Attachment #269113 -
Flags: review?(mark)
Comment 5•17 years ago
|
||
Comment on attachment 269113 [details] [diff] [review] fix v1.1 Please wait for the Camino tinderbox situation to be sorted out (should be done in the next week) before checking this in.
Attachment #269113 -
Flags: review?(mark) → review+
Attachment #269113 -
Flags: superreview?(ted.mielczarek)
Updated•17 years ago
|
Attachment #269113 -
Flags: superreview?(ted.mielczarek) → superreview+
Comment 6•17 years ago
|
||
Note for those building "at home": Even with this patch, you need to do "gcc_select 4.0" before building to get the Camino build to work on PPC systems. If gcc_select is set to "3.3", the Camino build will die (while doing xcodebuild -project Camino.xcode) with an error about the minimum supported target being greater than the maximum supported target. This is presumably because Camino.xcode/project.pbxproj explicitly sets MACOSX_DEPLOYMENT_TARGET to '10.3' and SDKROOT to '/Developer/SDKs/MacOSX10.3.9.sdk'. (If gcc_select is '4.0', these settings get changed to '10.4' and '/Developer/SDKs/MacOSX10.4u.sdk'. Camino.xcode does build with gcc_select set to '3.3' if you change the targets in Camino.xcode/project.pbxproj, but GCC_VERSION will be set to '3.3'.)
Comment 7•17 years ago
|
||
Completely untested Camino changes. I think this is everywhere we reference SDKs, but someone should give this a spin on PPC.
Updated•17 years ago
|
Attachment #270772 -
Attachment is patch: true
Attachment #270772 -
Attachment mime type: application/octet-stream → text/plain
Attachment #270772 -
Flags: superreview?(mark)
Blocks: 386915
Comment 8•17 years ago
|
||
> I think this is everywhere we reference SDKs
There's also
camino/IBPalette/CaminoViewsPalette.xcode/project.pbxproj, which sets
MACOSX_DEPLOYMENT_TARGET to 10.2 and SDKROOT to
/Developer/SDKs/MacOSX10.2.8.sdk.
But I'm not sure if this matters.
Please also land the patch in bug 386915 when this lands.
Comment 10•17 years ago
|
||
(In reply to comment #8) > But I'm not sure if this matters. I doubt it, since that project shouldn't pull in any core code.
Comment 11•17 years ago
|
||
We actually shouldn't set either the SDK or DT in CaminoViewsPalette.
Comment 12•17 years ago
|
||
Comment on attachment 270772 [details] [diff] [review] camino changes Cleared to land.
Attachment #270772 -
Flags: superreview?(mark) → superreview+
Assignee | ||
Comment 13•17 years ago
|
||
landed on trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: in-testsuite-
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•