Closed Bug 385221 Opened 13 years ago Closed 13 years ago

use 10.4 SDK on all tinderboxes and GCC 4 on PPC

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(2 files, 1 obsolete file)

We need to update build stuff to get all tinderboxes using the 10.4u SDK and GCC 4 on PPC.
The tinderboxes should already have the correct SDKs, right? So this is as simple as updating http://mxr.mozilla.org/mozilla/source/build/macosx/universal/mozconfig with the correct SDK paths and GCC info?
Attached patch fix v1.0 (obsolete) — Splinter Review
This does the minimum we need to do to get everything using 10.4u and GCC 4 for PPC.
Attachment #269110 - Flags: review?(mark)
Comment on attachment 269110 [details] [diff] [review]
fix v1.0

         case "${target_cpu}" in
             powerpc*)
-                dnl Architecture minimum 10.3
-                dnl export MACOSX_DEPLOYMENT_TARGET=10.3
-                export MACOSX_DEPLOYMENT_TARGET=10.2
+                dnl Architecture minimum 10.4
+                dnl export MACOSX_DEPLOYMENT_TARGET=10.4
+                export MACOSX_DEPLOYMENT_TARGET=10.4

This doesn't need to be in a switch anymore, since you get 10.4 on any platform.  Also, this string:

+                      [  --enable-macos-target=VER (default=10.4/ppc, 10.4/x86)

no longer needs to separate x86 and ppc.

-    GCC_VERSION=4.0

We should still leave GCC_VERSION set, just always to 4.0 without any conditional, because the rest of the config uses it.  If you want to just use the system default compiler (gcc_select) always, additional changes will be needed.
Attachment #269110 - Flags: review?(mark) → review+
Attached patch fix v1.1Splinter Review
Attachment #269110 - Attachment is obsolete: true
Attachment #269113 - Flags: review?(mark)
Comment on attachment 269113 [details] [diff] [review]
fix v1.1

Please wait for the Camino tinderbox situation to be sorted out (should be done in the next week) before checking this in.
Attachment #269113 - Flags: review?(mark) → review+
Attachment #269113 - Flags: superreview?(ted.mielczarek)
Attachment #269113 - Flags: superreview?(ted.mielczarek) → superreview+
Note for those building "at home":

Even with this patch, you need to do "gcc_select 4.0" before building
to get the Camino build to work on PPC systems.

If gcc_select is set to "3.3", the Camino build will die (while doing
xcodebuild -project Camino.xcode) with an error about the minimum
supported target being greater than the maximum supported target.
This is presumably because Camino.xcode/project.pbxproj explicitly
sets MACOSX_DEPLOYMENT_TARGET to '10.3' and SDKROOT to
'/Developer/SDKs/MacOSX10.3.9.sdk'.

(If gcc_select is '4.0', these settings get changed to '10.4' and
'/Developer/SDKs/MacOSX10.4u.sdk'.  Camino.xcode does build with
gcc_select set to '3.3' if you change the targets in
Camino.xcode/project.pbxproj, but GCC_VERSION will be set to '3.3'.)
Attached patch camino changesSplinter Review
Completely untested Camino changes. I think this is everywhere we reference SDKs, but someone should give this a spin on PPC.
Attachment #270772 - Attachment is patch: true
Attachment #270772 - Attachment mime type: application/octet-stream → text/plain
Attachment #270772 - Flags: superreview?(mark)
Blocks: 387168
> I think this is everywhere we reference SDKs

There's also
camino/IBPalette/CaminoViewsPalette.xcode/project.pbxproj, which sets
MACOSX_DEPLOYMENT_TARGET to 10.2 and SDKROOT to
/Developer/SDKs/MacOSX10.2.8.sdk.

But I'm not sure if this matters.
Please also land the patch in bug 386915 when this lands.
(In reply to comment #8)
> But I'm not sure if this matters.

I doubt it, since that project shouldn't pull in any core code.
We actually shouldn't set either the SDK or DT in CaminoViewsPalette.
Comment on attachment 270772 [details] [diff] [review]
camino changes

Cleared to land.
Attachment #270772 - Flags: superreview?(mark) → superreview+
landed on trunk
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.