385297 - Known Vulnerabilities in Mozilla Products has 97 validation markup errors

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Gérard Talbot]

Didier,
Mozilla is "An advocate for standards on the Net" 
https://www.mozilla.org/about/
"we're making one of the most standards-compliant browsers around. It would be
bad show to have an incompliant website."
mozilla.org Documentation Style Guide on validation
http://www.mozilla.org/contribute/writing/guidelines#validation

http://validator.w3.org/check?uri=http://www.mozilla.org/projects/security/known-vulnerabilities.html

The "Known Vulnerabilities in Mozilla Products" webpage also needs a bit of tuning so that it can meet 
mozilla.org Documentation Style Guide
http://www.mozilla.org/contribute/writing/guidelines
and
mozilla.org Markup Reference
http://www.mozilla.org/contribute/writing/markup

It can be optimized to use already available classes (1) and style declarations defined in m.o. stylesheets. This way, we avoid redundancy, over-declared CSS declarations, multiple definitions. 
The markup code can be optimized to use better semantic: currently, the webpage uses a lot of <br> (444 occurences of <br> to be precise) which is often a sign of poor semantic, and here, it seems to me to be the case.

The 97 validation markup errors are caused in great part because of misnested anchors: 

(one misnested anchor at around line 1154)
<a id="seamonkey1.0.8">
<h3 id="seamonkey1.1.1">Fixed in SeaMonkey 1.1.1 and 1.0.8</h3>

which I believe should+could be corrected like this:

<h3 id="seamonkey1.1.1">Fixed in SeaMonkey 1.1.1 and <a id="seamonkey1.0.8">1.0.8</a></h3>

--------


(1) e.g.: 

At line 77:

<p id="toc">
<a href="#Firefox">Firefox vulnerabilities</a><br>
<a href="#Thunderbird">Thunderbird vulnerabilities</a><br>
<a href="#SeaMonkey">SeaMonkey vulnerabilities</a><br>
<a href="#Mozilla">Mozilla Suite vulnerabilities</a><br>

<br>
<a href="older-vulnerabilities.html">Older vulnerabilities</a>
</p>

can be replaced with

<ul class="toc">
 <li><a href="#Firefox">Firefox vulnerabilities</a></li>
 <li><a href="#Thunderbird">Thunderbird vulnerabilities</a></li>
 <li><a href="#SeaMonkey">SeaMonkey vulnerabilities</a></li>
 <li><a href="#Mozilla">Mozilla Suite vulnerabilities</a></li>
 <li><a href="older-vulnerabilities.html">Older vulnerabilities</a></li>
</ul>

which is more compact, better semantic and is what is recommended at
http://www.mozilla.org/contribute/writing/markup#navigation

Cheers, Gérard

Comment 1

[Gérard Talbot]

Didier,

I can fix this bug. Is it ok if I fix the markup code? Or do you prefer to do it yourself?

Comment 2

[Basil Hashem [:baz]]

Didier & Gerard,

I've made a few minor changes and the page now validates as HTML 4.01 Strict. See http://validator.w3.org/check?uri=http://www.mozilla.org/projects/security/known-vulnerabilities.html

I did not go thru the algorithm that Gerard has and would suggest we wait until this coming Monday when the owner of this doc, Dan Veditz, is back in town. He should weigh in on the removal of <br>'s and adherence to the Mozilla.org guidelines.

Thanks. 

Comment 3

[Gérard Talbot]

Resolving as FIXED

The other part of this bug (better semantic, better markup code) has been filed under bug 431261.