385349 - Remove _toJSONString methods when native JSON support is added

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Christine Yen]

Remove methods that do what

String.prototype.parseJSON
Object.prototype.toJSONString

will do automatically:

http://lxr.mozilla.org/seamonkey/source/browser/components/sessionstore/src/nsSessionStore.js#1874
and possibly also in /browser/components/places/content/utils.js

Comment 1

[Simon Bünzli]

Not sure whether a general toJSONString function really helps for SessionStore:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/sessionstore/src/nsSessionStore.js&rev=1.62&mark=1926-1927#1913
Currently we just drop unwanted key/value pairs as we go - if we use toJSONString, we'd have to clone and prune the object first which might not be more effective.

Comment 2

[(not reading, please use [e-mail] instead)]

thanks for the info about toJSONString () in session store.

as gavin points out in bug #386789, we have parseJSON in nsSearchSuggestions.js, too.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

For what it's worth we do have native JSON support now.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

nsSessionStore.js and Places both were converted to use JSON.jsm, and then later to use native JSON, as far as I know (we're even removing JSON.jsm in bug 462774). Bug 458959 fixed the nsSearchService caller and most others, too, so I think this is probably fixed, at least in non-test code...

Comment 5

[Mark Banner (:standard8)]

I can't find anything using this now that shouldn't be.