385396 - Go back to vanilla sqlite files

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Shawn Wilsher :sdwilsh]

When we did the upgrade, we had to comment out a flag on the file because it would cause an error on windows only.  I filed a bug upstream, but the sqlite folks have WONTFIXed it, so we have to work around the issue.

First, we have to restore the flag that is commented out here:
http://mxr.mozilla.org/seamonkey/source/db/sqlite3/src/sqlite3.c#15794

Next, we have to modify the case statement here:
http://mxr.mozilla.org/seamonkey/source/storage/src/mozStorageAsyncIO.cpp#1436
Basically, we need to check that return result for SQLITE_IOERR, and if it is that, set rc to SQLITE_OK to ignore the error.  This solution sucks, but sqlite likes to delete temp files that it tells the OS to delete when they close it anyway.

Comment 1

[Shawn Wilsher :sdwilsh]

Upstream bug:
http://www.sqlite.org/cvstrac/tktview?tn=2441

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 3

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

Added a better description in the warning stating when it is safe to ignore.
r=mconnor on irc to land this, but I need post-landing review from vlad.

Comment 4

[Shawn Wilsher :sdwilsh]

Checking in storage/src/mozStorageAsyncIO.cpp;
new revision: 1.17; previous revision: 1.16
Checking in db/sqlite3/src/sqlite3.c;
new revision: 1.4; previous revision: 1.3

Not closing until this gets reviewed by vlad.

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

That seems to have done the trick, not building empty folders now. 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070622 Minefield/3.0a6pre Firefox/3.0 ID:2007062215 Vista HP

Comment 6

[Shawn Wilsher :sdwilsh]

The SQLite folks seem to think that we should never check the return value of delete.  I'm not super happy with this, but removing the logging code might be a better idea.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 269395 [details] [diff] [review]
v1.1

Yeah, looks fine, close away!