385398 - breakpad build fails on x86_64 in dump_symbols.cc

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Karl Tomlinson (:karlt)]

c++ -o dump_symbols.o -c -fvisibility=hidden -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -DBUILD_ID=0000000000 -I/home/karl/moz/mozilla/toolkit/airbag/airbag/src/common/linux/../..  -I../../../../../../dist/include   -I../../../../../../dist/include/breakpad_linux_common -I../../../../../../dist/include/nspr -I/usr/include -DMOZ_PNG_READ -DPNG_NO_MMX_CODE -DMOZ_PNG_WRITE -I/usr/include -I../../../../../../dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_ -DTRACING -g -fno-inline   -DMOZILLA_CLIENT -include ../../../../../../mozilla-config.h -Wp,-MD,.deps/dump_symbols.pp /home/karl/moz/mozilla/toolkit/airbag/airbag/src/common/linux/dump_symbols.cc
/home/karl/moz/mozilla/toolkit/airbag/airbag/src/common/linux/dump_symbols.cc: In function 'void<unnamed>::FixAddress(void*)':
/home/karl/moz/mozilla/toolkit/airbag/airbag/src/common/linux/dump_symbols.cc:131: error: cast from 'void*' to 'Elf64_Word' loses precision
/home/karl/moz/mozilla/toolkit/airbag/airbag/src/common/linux/dump_symbols.cc: In function 'void<unnamed>::FixAddress(void*)':
/home/karl/moz/mozilla/toolkit/airbag/airbag/src/common/linux/dump_symbols.cc:131: error: cast from 'void*' to 'Elf64_Word' loses precision

Comment 1

[(not currently active) Ted Mielczarek]

I figured the build would break somewhere on x86_64.  What we want is a patch to disable Breakpad on x86_64 Linux.

Comment 3

[Dave Camp (:dcamp)]

Attachment: disable breakpad on 64bit systems

Ted mentioned on IRC that 64bit builds should have breakpad disabled on all platforms, this patch does that.

Comment 4

[Steffen Wilberg]

The patch fixes the build for me, thanks.

Please use "cvs diff -up8" to create patches so that bugzilla's patch viewer can link to the source files:
http://developer.mozilla.org/en/docs/Creating_a_patch

Comment 5

[Dave Camp (:dcamp)]

checked in