38561 - Save as Draft crashes

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Phil Peterson]

Using the 5/8 build on NT (although this happened on the 5/5 build too

1. Open Template message (I was using my status report template)
2. Type something in the subject line
3. File | Save As | Draft
4. Boom.

I filed several talkback incidents. Here's a stack trace:

   MSVCRT.dll + 0x1628 (0x78001628) 
   MSVCRT.dll + 0x1465 (0x78001465) 
   nsMsgComposeAndSend::MimeDoFCC                                             
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 3963]
   nsMsgComposeAndSend::SendToMagicFolder 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 3593]
   nsMsgComposeAndSend::SaveAsDraft 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 3617]
   nsMsgComposeAndSend::DeliverMessage 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 2648]
   nsMsgComposeAndSend::GatherMimeAttachments
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 1028]
   nsMsgComposeAndSend::HackAttachments 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 2245]
   nsMsgComposeAndSend::Init 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 2570]
   nsMsgComposeAndSend::CreateAndSendMessage 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 3425]
   nsMsgCompose::_SendMsg 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgCompose.cpp, line 606]
   nsMsgCompose::SendMsg 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgCompose.cpp, line 704]
   XPTC_InvokeByIndex 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, 
line 139]
   nsXPCWrappedNativeClass::CallWrappedMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativeclass.cpp, 
line 915]
   WrappedNative_CallMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp, 
line 195]
   js_Invoke

Comment 1

[Phil Peterson]

Add crash and nsbeta2 keywords

Comment 2

[selmer (gone)]

Target M17.

Comment 3

[leger]

Putting on [nsbeta2-] radar.  Putting on [dogfood+] radar.  We pointy heads use 
this all the time for daily use.

Comment 4

[Scott MacGregor]

I'm not quite sure how a bug can be beta2 minus but dogfood+?? Shouldn't this be
M16 sounds like a serious dogfood bug to me. rhp, if you have a chance can you
fill in an estimated fix date in the status whiteboard?

Comment 5

[rhp (gone)]

Yes, I'm doing bug triage today as well as prioritizing my work. Will, 
reshuffle today.

- rhp

Comment 6

[rhp (gone)]

I'll dig in!

- rhp

Comment 7

[rhp (gone)]

Just checked in a fix for where this was crashing on me. I'm not 100% sure this 
is what phil was seeing so it will be good to have this tested. :-)

- rhp

Comment 8

[laurel]

This looks ok to me using 2000-05-18-08 m16 commercial builds on linux rh6.0,
mac OS 9.0 and NT 4.0.

Will put pmock on cc list -- he's QA Assigned in charge of Drafts/Templates, so
he'll test more in-depth when he covers his testplan.

Comment 9

[Phil Peterson]

Still crashes for me in the 5/18 build. Reopening.

Comment 10

[laurel]

What is your Template and Draft folder setup?  Local, online ?

Comment 11

[Phil Peterson]

Both are online. Strangely I didn't get Talkback this time though.

Comment 12

[laurel]

I've tried both online and local setups... does this happen for you on other
templates-->draft?  I personally think it's God's way of telling you not to deal
with status reports.

Comment 13

[Phil Peterson]

> does this happen for you on other templates-->draft?

Yes

Comment 14

[pmock]

Phil,

I saved a copy of your 5/15 Application Group status.  I trying to reproduce the 
problem on NT 4.0 SP6.  I will update bug shortly ....
/Peter

Changing qa assign to myself.

Comment 15

[rhp (gone)]

Ok, I thought my fix would handle the problem, but it turned out that this was 
an issue of OnStop listeners getting called twice. Jeff T fixed this problem in 
Bug #35908 and just checked it in. Now things are much more sane :-)

- rhp

*** This bug has been marked as a duplicate of 35908 ***

Comment 16

[pmock]

Phil,
 Sorry, I have not been able to reproduce the crash using today builds 
(2000-0518) on winnt, macos9.04, or linux 6.1.  I been trying (off/on) this 
afternoon.  

I'm concerned that we haven't been able to reproduce the problem.  Since Rich 
indicated that this is a duplicate bug, let wait for the next build.  If you're 
still experiencing the problem, let me take a look at your system (at your 
convenience) and see what I am doing wrong.  

I will wait until I hear back from you before verifying this bug.

/Peter

Comment 17

[Phil Peterson]

I can reproduce my crash with the 5/24 build (the last one I downloaded). Since
the dup of this bug was verified fixed before then, I think this is not really a
dup, and not fixed. Reopening.

Comment 18

[rhp (gone)]

I'm having real problems recreating this one. Can anyone else (aside from phil 
;-) make this crash like this?

- rhp

Comment 19

[pmock]

I'm working on trying to reproduce this bug...
I'll update bug shortly.

/Peter

Comment 20

[pmock]

I haven't been able to reproduce this problem yet using today 2000-0531-08 
builds on win98, winnt, macos, or linux.  It's frustrating...

I like to see it on Phil's machine.  Phil, do you have any time today to show me 
the problem?

Comment 21

[rhp (gone)]

Since this is a big flashing light on the dogfood scoreboard, I am going to 
mark works for me and you can reopen if this is still broken.

- rhp

Comment 22

[Phil Peterson]

I've demoed it about five times for pmock today, and submitted talkback reports.
Definitely still broken. I'm going to kick off a build in a couple minutes, so
maybe I can find something out in VC++

Comment 23

[pmock]

I'm at a lost why I can't reproduce this problem.  As Phil said, it crashes 
everytime on his system. Ack!
It's really beginning to annoy me... :(

Comment 24

[lchiang]

Phil - what happens if you change your draft folder to be local?

Comment 25

[rhp (gone)]

Phil, are you running a fresh build or the old one? 

- rhp

Comment 26

[pmock]

fyi,
 I experimented on Phil's PC.  If I create a profile for myself and follow the 
steps outlined, I can not reproduce the problem.  I created several new profiles 
configured for IMAP.  In each case, I was successful in modifying template and 
saving my changes to a draft.
 Phil needed his PC for PDT meeting so I had to cut my testing short.  I need to 
get a copy of Phil's prefs.js file.

Observation, in the "Mail & News Account Setting dialog, I noticed that under 
the Local Folder, it had sub-areas for "servers" and "copies and folders".  

It maybe a preference issue but I need to be sure and to make it work on Phil's 
profile.

Comment 27

[Phil Peterson]

I tried changing the draft folder to local, and still crashed. I'm running the
5/30 commecial build today. I mailed pmock my prefs file. Haven't gotten to
build the code I pulled though. Will try that tonight.

Comment 28

[pmock]

Rich,

I examined Phil's prefs.js file.  I tried using his setting (changing the 
path/directory names) but could not reproduce the problem on my NT 4.0 SP 6 or 
Win98 PCs

We tried moving the Drafts.MSF and Templates.MSF files from the IMAPmail 
directory in case the summary file was corrupted.   It did not help. Phil 
created a brand new profile for himself (not migrated) and still experiences the 
crash.  It crashes saving to the Drafts folder on the IMAP server or in the 
Local Folder.

It happens EVERY time on his PC.  I can't reproduce it on my machines.

There's one more thing we could check before Phil does a build.  We could turn 
on IMAP/POP logging.  To turn on IMAP/POP logging on NT you want to modify the 
system control panel. 
  1) Open Control Panel 
  2) Open System 
  3) Click on the Environment tab
  4) Use the tool to set the PRLOG env variables. 
       Variables: NSPR_LOG_MODULES   Value: IMAP:5 
       Variables: NSPR_LOG_FILE    Value: c:\tmp\[filename] 

Just a thought...

Comment 29

[rhp (gone)]

delete/release problem. Fixed.

- rhp

Comment 30

[pmock]

Phil,
Are you still experiencing this problem?  I haven't been able to reproduce this 
problem on my systems. 
/Peter

Comment 31

[Phil Peterson]

Verified fixed for me using 2000-06-04-20 on NT

Comment 32

[pmock]

Great Phil :-)