385635 - content overflows table cell

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Peter L Jones]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070623 Minefield/3.0a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070623 Minefield/3.0a6pre

At the bottom of the topic list on the example page, the "Goto ..." text links render over into the DIV containing the recent postings.

Reproducible: Always

Steps to Reproduce:
1. Visit site
2. Scroll down
3. See effect
Actual Results:  
The "Goto ..." text links render over into the DIV containing the recent postings.

Expected Results:  
The right edge of the text should line up with the left edge of the DIV

This changed with the nightly of 2007-06-21.

Comment 1

[Volkmar Kostka]

Can confirm that even for forums.mozillazine.org. Simply select a thread with several pages and you see the effect at the top and the bottom.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a6pre) Gecko/20070623 Minefield/3.0a6pre ID:2007062304

Comment 2

[M** A****]

Confirm heres a screen shot 
[URL=http://img406.imageshack.us/my.php?image=image1mk2.jpg][IMG]http://img406.imageshack.us/img406/9315/image1mk2.th.jpg[/IMG][/URL]

Comment 3

[Bill Gianopoulos [:WG9s]]

Confirming issue under both Win32 and Linux.

Assuming this is new textframe issue.  Changing component.

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase

Comment 5

[u88484]

Attachment: screenshot

Comment 6

[Dão Gottwald [:dao]]

I've also seen images overflowing table cells vertically. Not sure if that's the same bug.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That's probably a different bug.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Relatively simple bug and fix in min-width computation: when a word isn't entirely trimmable white-space, we need to clear existing aData->trailingWhitespace, because it's no longer trimmable, not being at the putative end of the line.

This patch also cleans up the pref-width computation to match min-width more closely.

Comment 9

[Simon Montagu :smontagu]

Comment on attachment 279685 [details] [diff] [review]
fix

This looks like the wrong patch

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: right patch

Comment 11

[Martijn Wargers (dead)]

Attachment: testcase2

I see a simlar problem on http://www.myanmar.com/religion/index.html
This is a testcase based on that site.

Comment 12

[Martijn Wargers (dead)]

Simon, could you review the patch?
I think this is also the reason why I get a horizontal scrollbar at http://news.google.nl/ .

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Simon, this is a pretty bad regression that I'd like fixed ASAP

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in.

The testcases in bug 393096 require this patch to pass, so we can mark this in-testsuite when those land.

Comment 15

[Martijn Wargers (dead)]

Ok, the url and the testcase are now worksforme.
My testcase2, http://www.myanmar.com/religion/index.html , and http://news.google.nl/ still show the issue, but I guess that's basically bug 393096.