Closed Bug 385733 Opened 17 years ago Closed 17 years ago

Remove "rate change limit" check from DownloadProgressListener

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha6

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch v1 (obsolete) — Splinter Review
rateChangeLimit is 0, so it'll end up changing every time anyway... so kill it! 

(needs bug 237693 checked in first)
Attachment #269653 - Flags: review?(sdwilsh)
Blocks: 385734
Is this already included in your other patch?
The attached patch is based on changes to bug 237693, so it isn't included in the patch for that bug.
ah, so it also cannot land until then, correct?

Also, please remove the check for the update interval since the back-end already does this.
Attachment #269653 - Flags: review?(sdwilsh)
Attached patch v2 (obsolete) — Splinter Review
(In reply to comment #3)
> ah, so it also cannot land until then, correct?
Correct. (Updated to diff off the other bug's latest patch v6)

> Also, please remove the check for the update interval since the back-end
> already does this.
Done.
Attachment #269653 - Attachment is obsolete: true
Attachment #270053 - Flags: review?(sdwilsh)
Attachment #270053 - Flags: review?(sdwilsh) → review+
Patch doesn't apply cleanly - please submit a new one.
Attached patch for checkinSplinter Review
Attachment #270053 - Attachment is obsolete: true
Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
new revision: 1.14; previous revision: 1.13
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha6
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: