Closed
Bug 385733
Opened 18 years ago
Closed 18 years ago
Remove "rate change limit" check from DownloadProgressListener
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha6
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file, 2 obsolete files)
3.11 KB,
patch
|
Details | Diff | Splinter Review |
rateChangeLimit is 0, so it'll end up changing every time anyway... so kill it!
(needs bug 237693 checked in first)
Attachment #269653 -
Flags: review?(sdwilsh)
Comment 1•18 years ago
|
||
Is this already included in your other patch?
Assignee | ||
Comment 2•18 years ago
|
||
The attached patch is based on changes to bug 237693, so it isn't included in the patch for that bug.
Comment 3•18 years ago
|
||
ah, so it also cannot land until then, correct?
Also, please remove the check for the update interval since the back-end already does this.
Updated•18 years ago
|
Attachment #269653 -
Flags: review?(sdwilsh)
Assignee | ||
Comment 4•18 years ago
|
||
(In reply to comment #3)
> ah, so it also cannot land until then, correct?
Correct. (Updated to diff off the other bug's latest patch v6)
> Also, please remove the check for the update interval since the back-end
> already does this.
Done.
Attachment #269653 -
Attachment is obsolete: true
Attachment #270053 -
Flags: review?(sdwilsh)
Updated•18 years ago
|
Attachment #270053 -
Flags: review?(sdwilsh) → review+
Comment 5•18 years ago
|
||
Patch doesn't apply cleanly - please submit a new one.
Assignee | ||
Comment 6•18 years ago
|
||
Attachment #270053 -
Attachment is obsolete: true
Comment 7•18 years ago
|
||
Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
new revision: 1.14; previous revision: 1.13
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha6
Updated•17 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•