385743 - Update from password manager to the new LoginManager on Trunk

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[arancaytar.ilyaran]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070622 Calendar/0.6a1

I cannot use the GData provider to create a calendar that is synchronized with my Google Calendar. The assistant finishes without displaying errors, but does not actually create the calendar.

Reproducible: Always

Steps to Reproduce:
1) I have installed the version of Sunbird mentioned, and the Google Calendar provider.

2) I have created a Google Calendar. It is not set to public.

3) I have copied the Private XML URL from the settings page and copied it into the text field after launching the assistant to create a new calendar ("On the Network" -> "Google Calendar").

4) I have followed the rest of the steps until the assistant is done.
Actual Results:  
The assistant will display the message that the new calendar has been created, and close. No calendar will actually appear in the list of calendars.


Expected Results:  
After creating a new calendar, it should appear in the list and display events.

- Using default theme
- Only other addons are Talkback and Cute Menus SVG
- I do not have administrative access to Windows. Sunbird runs from an extracted zip archive without having run an installer.

Comment 1

[Stefan Sitter [:ssitter]]

Reporter, do you see any error message in the Error Console (from Tools menu)?
Does the same issue exists using a stable Sunbird 0.5 build?

Comment 2

[arancaytar.ilyaran]

There are indeed two errors in the Error Console. Both are identical:

Error: Cc['@mozilla.org/passwordmanager;1'] has no properties
Source File: file:/// [extension path] js/calGoogleUtils.js
Line: 382

The command that triggers the error is this:

    var passwordManager = Cc["@mozilla.org/passwordmanager;1"].
                          getService(Ci.nsIPasswordManager);

--

This issue does not occur in Sunbird 0.5rc2.

Comment 3

[Shawn Wilsher :sdwilsh]

Is sunbird 0.5 on trunk?  They did just remove the password manager...

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
Sunbird 0.5 is build from MOZILLA_1_8_BRANCH.
Sunbird 0.6a1 is build from TRUNK.
Do you happen to know what bug removed the password manager?

Comment 5

[Justin Dolske [:Dolske]]

(In reply to comment #2)
 
>     var passwordManager = Cc["@mozilla.org/passwordmanager;1"].
>                           getService(Ci.nsIPasswordManager);

If Sunbird is using the Toolkit password manager on trunk, that code won't work any more... Bug 374723 changed the implementation and interfaces. My blog post and comments have some more info...
http://blog.mozilla.com/dolske/2007/05/28/followup-password-manager-changes-coming-in-ff3-alpha-5/

OTOH, if Sunbird is using wallet I *think* that should still be working. We left the old .idl and .h files (which were shared between wallet and toolkit/pwmgr), so that projects like SeaMonkey could have time to migrate off wallet.

I'm obviously not familiar with the calendar code, but this should be enough to point someone in the right direction.

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Yes, I know of this issue, thanks for filing the bug about it. Reducing to at least normal, since the obvious easy workaround is to use branch. The calendar tree is in sync between trunk and branch.

Justin, thank you for the additional info.

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Add support for nsILoginManager

This should do it - at least in theory. I cannot build a working trunk right now, so I can't test it. I will request review as soon as its tested on trunk.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Add support for nsILoginManager - v2

This patch does it and also gets rid of some strings that aren't really needed. Specifically, those of the login dialog. I now get them from passwordmgr/necko.

Comment 10

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 271698 [details] [diff] [review]
Add support for nsILoginManager - v2

Looks like my moving review and daniels granting review got overwritten. r+

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED