385794 - Save session on quit not offered if still service window open

Status: RESOLVED DUPLICATE of bug 417675

(Firefox :: General, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If the last browser window (with content area) is closed and service windows like the error console or the add-ons manager are open, Firefox doesn't offer to save the session. Having this feature would be useful.

Comment 1

[Michael Wu [:mwu]]

That wouldn't work out as session restore doesn't restore windows like the addons manager. Also, restoring firefox with just an error console or addons manager isn't too useful.

Comment 2

[Simon Bünzli]

You should get the Quit dialog once the last window (browser or non-browser) is closed. This is WORKSFORME, unless you ask for the Quit dialog to always be shown when the last browser window is closed (which would make even more sense once bug 354894 is fixed). Anyway: no DUPE.

(In reply to comment #1)
That's bug 385084 and would probably lead to both browser and non-browser windows being restored together (as also proposed for popups in bug 368677).

Comment 5

[Lucienp]

Since they closed the bug as a duplicate (although it's not really), I'm copying the text of 409492 below.  Likewise, my vote would be to have the option to save session offered anytime you close any window with multiple tabs and that that option would include:

1 SAve this window's tabs, but don't quit other windows
2 Save this window's tabs and quit
3 Save all tabs from all windows and quit
4 quit

If option 1 is selected, closing another window later with multiple tabs should append that data to the existing one so that all windows are restored on return (effectively a delayed implementation of option 3) 

Thanks to everyone for integrating this - it's one of my favorite Add-Ons in prior versions.

William   2007-12-21 16:18:01 PDT

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre)
Gecko/2007122105 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre)
Gecko/2007122105 Minefield/3.0b3pre

When I have multiple windows of "Minefield" (firefox 3) open, only the last one
I try to close will give me the option to "save and quit."

Reproducible: Always

Steps to Reproduce:
1.
2.
3.


Expected Results:  
Let you "save and quit" after closing each window

Comment #1 [reply] Jesse Ruderman  2008-02-15 02:04:52 PDT

See also bug 368677.

Comment #2 [reply] Jonathan Jacobs  2008-02-15 02:08:51 PDT

Performing File -> Exit will save (and restore) all tabs in all windows.
Closing windows one by one (e.g. clicking the window's X in Windows) will only
save the tabs in the final window.

What about optionally getting a "You have multiple windows open: [Exit],
[Close], [Cancel]" prompt that would perform File -> Exit, File -> Close Window
and cancel the request respectively?

Comment #3 [reply] Aru Sahni  2008-02-25 12:29:20 PDT

I've noticed a similar behavior with the Minefield builds.  If I have a window
with multiple tabs open and a download manager window open, I won't get
prompted to save my tabs if I close the browser window first.  I'd think the
optimal solution would be to treat non-browser windows as "secondary" and do
the following:

1.) User closes browser window while secondary windows open
2.) Firefox detects that the current browser window is the last browser window
open, and will prompt the user to save their session or to just quit.
3.) User selects "save and quit", happy to see that the browser will restore
his tabs when he launches his browser
4.) (optional) restore secondary windows?

Comment #4 [reply] Simon Bünzli (busy)  2008-03-27 14:05:13 PDT

*** This bug has been marked as a duplicate of bug 385794 ***

Comment 6

[Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)]

I agree partially with this bug. 

An example: if the download manager is opened and you close last Firefox window, Firefox process will not be closed and you can still download something in queue.

If this bug will be fixed without taking this into account, when you close Firefox you can abort unintentionally downloads, bugs reports, extension installations etc. Firefox should quit (and ask to save session) only if not-browsing windows are in a "not working" state.

Comment 7

[Simon Bünzli]

The Save Session prompt isn't displayed by Session Restore but by browser glue. -> Firefox:General