Closed
Bug 385838
Opened 17 years ago
Closed 16 years ago
POP3: don't sync after each header
Categories
(MailNews Core :: Backend, enhancement)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: hyc, Assigned: hyc)
Details
(Keywords: perf)
Attachments
(2 files)
802 bytes,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
911 bytes,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Normally a full flush/sync occurs after each item is downloaded in a POP3 session, to minimize risk of data loss. This sync guarantees that a downloaded message has been saved successfully on the local disk before deleting it on the server. When using header-only downloads this precaution is unnecessary since the full message still resides on the server. Avoiding the sync in this case is helpful since it reduces hard drive activity/wear/tear and improves throughput. The improvement is really noticeable when there are hundreds or thousands of messages in a mailbox. (On one of my accounts I typically get 700 messages/day, mostly spam.)
Assignee | ||
Comment 1•17 years ago
|
||
It might be acceptable to skip the sync when "Leave on Server" is true too, but I haven't thought about that too deeply yet.
Updated•17 years ago
|
Attachment #269769 -
Flags: superreview?(bienvenu)
Comment 2•17 years ago
|
||
Comment on attachment 269769 [details] [diff] [review] [checked in]Patch to nsPop3Sink.cpp sorry for the delay; I'll land this today.
Attachment #269769 -
Flags: superreview?(bienvenu) → superreview+
Comment 3•17 years ago
|
||
Comment on attachment 269769 [details] [diff] [review] [checked in]Patch to nsPop3Sink.cpp I guess I'll leave this open to consider the pop3 leave on server case.
Attachment #269769 -
Attachment description: Patch to nsPop3Sink.cpp → [checked in]Patch to nsPop3Sink.cpp
Comment 4•16 years ago
|
||
(In reply to comment #1) > It might be acceptable to skip the sync when "Leave on Server" is true too, but > I haven't thought about that too deeply yet. leave on server is my default. I wonder if this is heavily used? change to component=n:pop?
Keywords: perf
Updated•16 years ago
|
Product: Core → MailNews Core
Comment 5•16 years ago
|
||
Howard wrote in comment #1: > It might be acceptable to skip the sync when "Leave on Server" is true too, but > I haven't thought about that too deeply yet. Howard do you also want to take the step for "Leave on Server"?
Assignee | ||
Comment 6•16 years ago
|
||
Sorry, I forgot about this. It's a trivial check.
Assignee | ||
Updated•16 years ago
|
Attachment #333909 -
Flags: review? → review?(bienvenu)
Comment 7•16 years ago
|
||
Comment on attachment 333909 [details] [diff] [review] Also check LeaveOnServer setting I'll try to land this soon.
Attachment #333909 -
Flags: superreview+
Attachment #333909 -
Flags: review?(bienvenu)
Attachment #333909 -
Flags: review+
Comment 8•16 years ago
|
||
bienvenu: need some help landing it, or just help remembering? ;)
Comment 9•16 years ago
|
||
that second one :-)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Target Milestone: --- → Thunderbird 3.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•