multipart/form-data submission broken on 0.8

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
10 years ago
a year ago

People

(Reporter: aaronr, Assigned: aaronr)

Tracking

({fixed1.8.1.5})

1.8 Branch
x86
All
fixed1.8.1.5

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

2.21 KB, patch
smaug
: review+
Doron Rosenberg (IBM)
: review+
Details | Diff | Splinter Review
3.01 KB, patch
smaug
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 269786 [details] [diff] [review]
patch

Looks like there is a bug on the 1.8 branch that prevents the patch that fixed multipart/form-data on the trunk from working on the branch.  When we go to set the nsXFormsAtoms::uploadFileProperty on the clone of the instance data node that originally contained it, it is failing to work correctly.  By that point we've already done the ImportNode, but not the AppendChild.  ImportNode should set up the owner document for the cloned node to be the submission document, but that doesn't seem to be the case since the owner document before appendchild and after are different.

So to work around this 1.8 bug we'll just set the property AFTER we've done the call to AppendChild.

Testcase: https://bugzilla.mozilla.org/attachment.cgi?id=247929
Attachment #269786 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

10 years ago
Attachment #269786 - Flags: review?(doronr)

Updated

10 years ago
Attachment #269786 - Flags: review?(Olli.Pettay) → review+

Updated

10 years ago
Attachment #269786 - Flags: review?(doronr) → review+
(Assignee)

Comment 1

10 years ago
checked into trunk
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Comment 2

10 years ago
Reopening bug.  I didn't move the statement high enough to fix uploads bound to attributes.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 3

10 years ago
Created attachment 270088 [details] [diff] [review]
patch2

just asking for one review.  It is a pretty minor change, more of a correction of the first change.  But I don't want to be accused of breaking the rules :-)
Attachment #270088 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

10 years ago
Blocks: 376307

Updated

10 years ago
Attachment #270088 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 4

10 years ago
checked patch2 into trunk and patches 1 and 2 into 1.8 branch.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Keywords: fixed1.8.1.5
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.