Closed
Bug 385870
Opened 18 years ago
Closed 18 years ago
[FIX]Incorrect layout for textarea with both "left" and "right" properties
Categories
(Core :: Layout: Form Controls, defect, P3)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: erik, Assigned: bzbarsky)
References
(Depends on 1 open bug)
Details
(Keywords: regression, testcase)
Attachments
(2 files)
|
754 bytes,
text/html
|
Details | |
|
3.21 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
dbaron
:
approval1.9+
|
Details | Diff | Splinter Review |
If both left and right are set the element should adjust its width so that both the left and right are fulfilled. This works great with divs and other non form elements.
Same applies to top and bottom.
|
Reporter | |
Comment 1•18 years ago
|
||
Actually top+bottom seems to work OK.
|
||
Comment 2•18 years ago
|
||
Rewording summary so it's clear that this bug isn't about arrow keys.
Summary: Left + right does not work correctly for text areas → Incorrect layout for textarea with both "left" and "right" properties
|
|
||
Updated•18 years ago
|
Keywords: regression,
testcase
|
|
||
Comment 3•18 years ago
|
||
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite?
Resolution: --- → INVALID
|
|
||
Comment 4•18 years ago
|
||
Oops, wait a sec, I marked this too fast; we're not following http://www.w3.org/TR/CSS21/visudet.html#abs-replaced-height correctly.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
|
|
||
Comment 5•18 years ago
|
||
It looks like we need another codepath to deal with this situation; textareas are replaced and have an intrinsic height, but don't have an intrinsic ratio like images.
|
|
Assignee | |
Comment 6•18 years ago
|
||
Assignee: nobody → bzbarsky
Status: REOPENED → ASSIGNED
Attachment #276239 -
Flags: superreview?(dbaron)
Attachment #276239 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 7•18 years ago
|
||
Needs a regression test, still... I guess I'll write one when I go to check in if someone doesn't get to it before that.
OS: Windows Vista → All
Priority: -- → P3
Hardware: PC → All
Summary: Incorrect layout for textarea with both "left" and "right" properties → [FIX]Incorrect layout for textarea with both "left" and "right" properties
Target Milestone: --- → mozilla1.9 M9
Comment on attachment 276239 [details] [diff] [review]
Fix for the height issue
r+sr+a1.9=dbaron
Attachment #276239 -
Flags: superreview?(dbaron)
Attachment #276239 -
Flags: superreview+
Attachment #276239 -
Flags: review?(dbaron)
Attachment #276239 -
Flags: review+
Attachment #276239 -
Flags: approval1.9+
|
|
Assignee | |
Comment 9•18 years ago
|
||
Checked in, with tests.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 18 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Updated•18 years ago
|
Attachment #276239 -
Attachment description: Fix for the heigth issue → Fix for the height issue
You need to log in
before you can comment on or make changes to this bug.
Description
•