DM should cache the query that nsDownload::UpdateDB uses

RESOLVED FIXED in mozilla1.9alpha7

Status

()

Toolkit
Downloads API
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: sdwilsh, Assigned: sciguyryan)

Tracking

Trunk
mozilla1.9alpha7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

11 years ago
When downloading, it can get called once every 400ms.  We can toss this in a member variable in nsDownloadManager and create it in Init (or lazily create it) instead of creating it each and ever single time.
(Assignee)

Updated

11 years ago
Assignee: nobody → sciguyryan
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

11 years ago
Created attachment 270417 [details] [diff] [review]
Patch v1.0

Patch v1.0

Like so?
Attachment #270417 - Flags: review?(sdwilsh)
(Reporter)

Comment 2

11 years ago
Comment on attachment 270417 [details] [diff] [review]
Patch v1.0

Nearly - please remove this too:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp&rev=1.92#66

Did you by chance run the unit tests for this component?
Attachment #270417 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 3

11 years ago
Created attachment 270423 [details] [diff] [review]
Patch v1.1

Patch v1.1

Updated to tip.
Attachment #270417 - Attachment is obsolete: true
(Reporter)

Updated

11 years ago
Attachment #270423 - Flags: review+
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]
(Reporter)

Updated

11 years ago
Flags: in-testsuite-
Target Milestone: --- → Firefox 3 beta1
(Reporter)

Comment 4

11 years ago
Checking in toolkit/components/downloads/src/nsDownloadManager.h;
new revision: 1.30; previous revision: 1.29
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.94; previous revision: 1.93
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.