Closed
Bug 385876
Opened 17 years ago
Closed 17 years ago
DM should cache the query that nsDownload::UpdateDB uses
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha7
People
(Reporter: sdwilsh, Assigned: sciguyryan)
Details
Attachments
(1 file, 1 obsolete file)
|
4.12 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
When downloading, it can get called once every 400ms. We can toss this in a member variable in nsDownloadManager and create it in Init (or lazily create it) instead of creating it each and ever single time.
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → sciguyryan
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•17 years ago
|
||
Comment on attachment 270417 [details] [diff] [review] Patch v1.0 Nearly - please remove this too: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp&rev=1.92#66 Did you by chance run the unit tests for this component?
Attachment #270417 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Patch v1.1 Updated to tip.
Attachment #270417 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•17 years ago
|
Attachment #270423 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [checkin needed]
|
|
Reporter | |
Updated•17 years ago
|
Flags: in-testsuite-
Target Milestone: --- → Firefox 3 beta1
|
|
Reporter | |
Comment 4•17 years ago
|
||
Checking in toolkit/components/downloads/src/nsDownloadManager.h; new revision: 1.30; previous revision: 1.29 Checking in toolkit/components/downloads/src/nsDownloadManager.cpp; new revision: 1.94; previous revision: 1.93
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•