When downloading, it can get called once every 400ms. We can toss this in a member variable in nsDownloadManager and create it in Init (or lazily create it) instead of creating it each and ever single time.
Created attachment 270417 [details] [diff] [review] Patch v1.0 Patch v1.0 Like so?
Attachment #270417 - Flags: review?(sdwilsh)
Comment on attachment 270417 [details] [diff] [review] Patch v1.0 Nearly - please remove this too: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp&rev=1.92#66 Did you by chance run the unit tests for this component?
Attachment #270417 - Flags: review?(sdwilsh) → review+
Created attachment 270423 [details] [diff] [review] Patch v1.1 Patch v1.1 Updated to tip.
Attachment #270417 - Attachment is obsolete: true
Target Milestone: --- → Firefox 3 beta1
Checking in toolkit/components/downloads/src/nsDownloadManager.h; new revision: 1.30; previous revision: 1.29 Checking in toolkit/components/downloads/src/nsDownloadManager.cpp; new revision: 1.94; previous revision: 1.93
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.