385962 - add support for "mar -c foo.mar -" to read file list from stdin

Status: RESOLVED WONTFIX

(Core :: General, enhancement)

Description

[Trent Mick]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: 

The current simple mar executable (in modules/libmar/tool/) takes a list of files to archive on the command line:

  mar -c foo.mar file1 file/two another/file

With a large set of files (e.g. we hit this in Komodo) it is easy to hit the cmd.exe limit on command length on Windows. The provide patch allows one to pass in the list of files on stdin (one file per line):

  mar -c foo.mar - < list-of-files.txt




Reproducible: Always

Comment 1

[Trent Mick]

Attachment: patch to mar.c to add "mar -c foo.mar -" support

Comment 2

[Trent Mick]

The patch all prefixes "mar: " to a couple of error messages in libmar. In a deep build chain this can really help pinpoint where the error message came from.

Comment 3

[Adam Guthrie]

You might try asking Darin Fisher (darin.moz@gmail) for review on the patch. Looks like he's about the only one who's touched libmar.

Comment 4

[Trent Mick]

Thanks, Adam. Done. I'd tried to set "review ? darin" when I first attached the patch, but obviously didn't get it right.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

no need