385977 - Implement filesystem viewer

Status: RESOLVED WONTFIX

(Other Applications Graveyard :: XUL Explorer, enhancement)

Description

[Daniel Kirsch]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

Implement a filesystem viewer in the sidebar

Reproducible: Always

Comment 1

[Daniel Kirsch]

Attachment: Implementation proposal.

Copy the zip content into the "content" folder. The filesystem binding isn't finished yet and the rdf implementation has a couple of limitations. The catalog category binding needs some polish.

Comment 2

[Daniel Kirsch]

The proposal also adds the catalog widget which might be used instead of a deck for the sidebar. This way, each view is always visible - at least by a clickable button. I'm not happy with the design, but if that's a way to go, I'm going to start Photoshop :-)

Comment 3

[Alex Vincent [:WeirdAl]]

Screenshots?

Comment 4

[Daniel Kirsch]

Ah, I see. Good idea. I will provide some as soon as I'm back at home.

Comment 5

[Daniel Kirsch]

Attachment: Screenshot

Screenshot of the current implementation. On the left you see "Snippets", "File Explorer" and "About". Clicking one of these will show the category and hide the previously shown one. Double clicking on a file, opens that in the editor. Currently no filter is defined nor definable. This might be a good enhancement.

Comment 6

[Daniel Kirsch]

Attachment: Sidebar proposal

This is a proposal (Currently just a Photoshop snapshot). The sidebar and the views (Snippets, Files, DOM) might look like this.

Comment 7

[Mukunda]

Attachment: use XBL Binding for <sidebars/> and <sidebar> widgets

Here is an alternate implementation for the sidebar user interface. See discussion in mozilla.community.mozpad and specifically this message: 
http://groups.google.com/group/mozilla.community.mozpad/msg/95156662cdcc6f97

Comment 8

[Mukunda]

That patch is mainly an adaptation of the menudeck from xulwidgets.mozdev.org. Alternate user interfaces could be implemented to allow users to choose a preferred style, e.g.  <sidebars type="catalog"> or <sidebars type="tabs">

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 271052 [details] [diff] [review]
use XBL Binding for <sidebars/> and <sidebar> widgets

>+	<binding id="sidebars_menudeck">
>+		<content>
>+		  <xul:box xbl:inherits="orient">
>+			<xul:hbox class="paneheader">
>+				<xul:menulist><xul:menupopup/></xul:menulist>
>+				<children includes="sidebarheader"/>
>+			</xul:hbox>
>+			<xul:deck xbl:inherits="selectedIndex" flex="1"><children/></xul:deck>
>+		  </xul:box>
>+		</content>

<menulist> is not very attractive in the pane header, especially on windows. MS Office for example uses a control like <button type="menu"../>

Also, there are some runtime JS errors in explorer.js

Comment 10

[Mukunda]

Attachment: updated to address js errors and improve the menulist appearance

cleaned up a few problems. should be no more js errors and the appearance is slightly better. Note: the style for menulist is now hard-coded in the sidebars xbl binding, I have no excuse for doing it that way but I will come up with something better soon.

Comment 11

[Mukunda]

I'm sorry, that last patch left out one new file: 

Index: trunk/app/chrome/skin/standard/bindings.css
===================================================================
--- trunk/app/chrome/skin/standard/bindings.css (revision 0)
+++ trunk/app/chrome/skin/standard/bindings.css (revision 0)
@@ -0,0 +1,12 @@
+sidebars[type="deck"] {
+  -moz-binding: url("chrome://explorer/content/bindings/sidebars.xbl#sidebars_menudeck");
+}
+sidebar {
+  -moz-binding: url("chrome://explorer/content/bindings/sidebars.xbl#sidebar_box");
+}
+sidebar[src] {
+  -moz-binding: url("chrome://explorer/content/bindings/sidebars.xbl#sidebar_frame");
+}
+sidebarheader {
+  -moz-binding: url("chrome://explorer/content/bindings/sidebars.xbl#sidebar_header");
+}
\ No newline at end of file

Comment 12

[Alex Vincent [:WeirdAl]]

ActiveState's OpenKomodo project (not yet available to the general public) already implements this capability.  Maybe we could persuade them to donate code here.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

XUL Explorer is a dead project. We are not going to fix these bugs.