385988 - Update malware UI to use Places' drop-down-from-location-bar look and feel

Status: RESOLVED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[Johnathan Nightingale [:johnath]]

Bug 380932 created the error page visual for blocked malware sites but there was discussion in that bug about using an alert which dropped down from the location bar, much as the FF3 Places UI is intended to do.  

Review comments in that bug requested that this bug be filed to track the outstanding request to investigate this UI treatment once the places UI is available for use/adaptation.

Comment 1

[Gábor Stefanik]

Is this mac-only? If not, change hardware/OS accordingly.

Comment 2

[Johnathan Nightingale [:johnath]]

This bug is outdated.  When we were certain we were getting all our notifications moved up into popouts from the favicon, this was an attempt to ensure that malware was included in that transition.  However, the drop-down-from-location-bar notifications didn't materialize for FF3, and while there is current discussion about a similar concept, I think the intent is to use it for very simple notifications, which the phishing/malware pages are not.

It is entirely legitimate for us to talk about moving from the error pages to something else once that something else exists, but I think the discussion has moved on from the type of approach described here, so I'm going to resolve the bug INVALID, since it assumes we will use an API which doesn't exist, and maybe won't exist.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Johnath: one kind of quirky thing is that on the malware error page the site button contains grey Larry saying that the page does not provide identity information (even though red Larry is in the content area).  Even though we want to keep the content are message, shouldn't the site button contain a red Larry and a similar message. Or is there a separate bug for that?

Comment 4

[Johnathan Nightingale [:johnath]]

(In reply to comment #3)
> Johnath: one kind of quirky thing is that on the malware error page the site
> button contains grey Larry saying that the page does not provide identity
> information (even though red Larry is in the content area).  Even though we
> want to keep the content are message, shouldn't the site button contain a red
> Larry and a similar message. Or is there a separate bug for that?

Yep. :)  bug 428948