386145 - Title bar is not updated to 100% when sending of a DCC file is completed

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[worms]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1
Build Identifier: ChatZilla 0.9.77-2007032319 [SeaMonkey 1.1.1/2007022206]

The title bar isn't updated to 100% after the file sent is finished.

Reproducible: Always

Steps to Reproduce:
1.Send a DCC file to some user
2.Wait for the message: DCC File Transfer of “thing.stuff” to “some user” (IP) finished.
3.Look at title bar
Actual Results:  
The title bar says:
99% (or 92%...) of thing.stuff sent to "some user"


Expected Results:  
100% should show in the title bar, as a message saying:
DCC File Transfer of “thing.stuff” to “some user” (IP) finished.

Reproducable also on ChatZilla 0.9.78.1-rdmsoft [XULRunner 1.8.0.9/2006120508]

Comment 1

[James Ross]

I think this just needs updateTitle() added after the updateProgress line in CIRCDCCFileTransfer.prototype.onDisconnect. Having said that, I think onAbort and onFail need the same treatment.

Comment 2

[:Gijs (he/him)]

Attachment: Patch

Done what was suggested in comment #1, and made .progress actually always work (and not just if you happened to have run onProgress). Works fine now, afaict! :-)

Comment 3

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/js/lib/dcc.js;
/cvsroot/mozilla/extensions/irc/js/lib/dcc.js,v  <--  dcc.js
new revision: 1.20; previous revision: 1.19
done
Checking in mozilla/extensions/irc/xul/content/commands.js;
/cvsroot/mozilla/extensions/irc/xul/content/commands.js,v  <--  commands.js
new revision: 1.147; previous revision: 1.146
done
Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.171; previous revision: 1.170
done
Checking in mozilla/extensions/irc/xul/content/output-window.js;
/cvsroot/mozilla/extensions/irc/xul/content/output-window.js,v  <--  output-window.js
new revision: 1.20; previous revision: 1.19
done