386164 - crashreporter expects "Vendor" to be existing

Status: RESOLVED DUPLICATE of bug 396209

(Toolkit :: Crash Reporting, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

crashreporter expects "Vendor" to be existing

Vendor is an optional field in application.ini but if it's not set the crash reporter on Windows saves to the registry key Software\Crash Reporter and therefore treats Vendor to be mandatory.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

I wonder if
http://mxr.mozilla.org/seamonkey/source/toolkit/airbag/client/crashreporter_win.cpp#699
was intended to fall back to Software\Mozilla\Crash Reporter but doesn't do it because Vendor could be found in gQueryParameters but is empty?

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Aehm, forgot my proposal: Fall back to product/Name/ProductName if Vendor is
empty/not defined.

Comment 3

[(not currently active) Ted Mielczarek]

Looks like we should probably be testing the string here to see if it's an empty string:
http://mxr.mozilla.org/seamonkey/source/toolkit/xre/nsAppRunner.cpp#2524

But this might be obviated by bent's fix over on bug 396486.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Rolled into the patch on bug 396209.