386333 - Page Info knows nothing about dataURL images embeded via CSS

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[sendmail.to]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4

 

Reproducible: Always

Steps to Reproduce:
1. load testcase
2. go to page info

Actual Results:  
You see there are no infos like height and width.


This also occurs on trunk with the new page info dialog.

This problem does not occur if you embed a dataURL into <image> src attribute.
This seams to be a CSS only problem.
When using dataURLs like this:

background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABQAAAA..........");

Comment 1

[sendmail.to]

Attachment: Testcase for this Bug

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Follow-up from bug 426029 (background images with data url)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The patch above is a follow-up from the patch created by Florian on bug 426029.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 371164 [details] [diff] [review]
Follow-up from bug 426029 (background images with data url)

r=mano

Comment 6

[Philip Chee]

Attachment: Testcase 2: Test edge cases.

Test with a different data url format plus uppercase image mime type. See Bug 491310 Comment 24.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, I will update the patch with the comments made in comment 6 by Philip.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Philip, for the given testcase there isn't shown a media tab at all. Do we miss something which is already patched for SeaMonkey?

Comment 9

[Philip Chee]

This is Bug 494808 - Page Info > Media doesn't list background images anymore
Due to:
Bug 322475 - Implement support for CSS3 multiple backgrounds

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Philip. Means I will to wait until bug 494808 has been fixed.

Comment 11

[Philip Chee]

Henrik, Bug 504822 removes XBM support from trunk so your original patch in comment 3 should be good to go.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #6)
> Created an attachment (id=384677) [details]
> Testcase 2: Test edge cases.
> 
> Test with a different data url format plus uppercase image mime type. See Bug
> 491310 Comment 24.

Why is no background shown anymore in this testcase?

Comment 13

[Philip Chee]

> Why is no background shown anymore in this testcase?

Because, as I said:

> Bug 504822 removes XBM support from trunk

So test case 2 is invalid.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry for the delay. The already reviewed patch still applies very well and fixes the problem. Anyone who can please checkin?

Comment 15

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3e6e68417176
http://hg.mozilla.org/mozilla-central/rev/a4303a416630

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, I missed that bug for a while. Now it's too late for 3.6.

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20100115 Minefield/3.7a1pre ID:20100115050858