386336 - Strict warning: short/long is a reserved identifier (in calendar-multiday-view.xml)

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Using Thunderbird 2.0.0.5pre (20070627) with Lightning 0.5pre (2007062907)

Switching to Day view or Week view produces dozens of strict warnings like

Warning: short is a reserved identifier
Source file: chrome://calendar/content/calendar-multiday-view.xml
Line: 1802, Column: 14
Source code:
          var short = document.getAnonymousElementByAttribute(this, "anonid", "shortWeekdayName"); 

Warning: long is a reserved identifier
Source file: chrome://calendar/content/calendar-multiday-view.xml
Line: 1803, Column: 14
Source code:
          var long = document.getAnonymousElementByAttribute(this, "anonid", "longWeekdayName"); 

Same warnings also for lines 1806, 1807, 1819, 1820, 1823, 1826, 1827, 1829, 1830, 1834, 1844, 1845, 1846, 1847

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix variable names - v1

This should do it. It seems I didn't have strict warnings on in that build...

Comment 2

[Michael Büttner (no reviews TFN)]

Comment on attachment 270476 [details] [diff] [review]
Fix variable names - v1

I also didn't stumble across this while reviewing, nice catch. r=mickey.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 4

[Andreas Treumann]

Verified -> task is fixed.