Closed Bug 386361 Opened 17 years ago Closed 16 years ago

Page Info no longer displays whether page is in quirks / standards compliance mode

Categories

(Firefox :: Page Info Window, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 beta2

People

(Reporter: ispiked, Assigned: florian)

References

Details

(Keywords: regression)

Attachments

(2 files)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070629 Minefield/3.0a6pre

Gavin tells me that this got nuked in bug 339102. This is a very useful feature for web developers and needs to be added back.
Web developers can install the web developer toolbar. I think the bigger question is what use is this to regular users?

Personally I liked using it to point out that the websites they are seeing aren't using standards compliant rendering.
Web developers can, indeed; however, it's been implicated in so many bugs that testers/triagers cannot. If only we knew of an extension that they all have installed anyway, that could bring it back...
Flags: blocking-firefox3?
See also bug 346500 that can be wontfixed if we don't fix this I think.
Flags: blocking-firefox3? → blocking-firefox3+
We need to figure out what things in Page Info are important, generally speaking, but I believe understanding how we're rendering something should be displayed.
Assignee: nobody → f.qu
Target Milestone: --- → Firefox 3 M10
Indeed, rendering mode is an important info for developers and users as we can point out that the webpage is not triggering standards compliant rendering mode.

Voting for this bug.
Depends on: 346500
Keywords: uiwanted
What's "uiwanted" about this bug? Beltzner has already said that we should re-add it, and mconnor marked it blocking :)
It should be re-added. Discussion about whether or not the string could be made to be more user friendly is in bug 346500.
Keywords: uiwanted
Attached patch patch v1Splinter Review
Add it back like it was before 339102.

Note: this displays "Quirks mode" for standalone images, not sure we should do that. Maybe it would be better to hide the line in this case.
Attachment #286080 - Flags: review?(mano)
Comment on attachment 286080 [details] [diff] [review]
patch v1

r=mano
Attachment #286080 - Flags: review?(mano) → review+
Target Milestone: Firefox 3 M10 → Firefox 3 M11
Checking in browser/base/content/pageinfo/pageInfo.js;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.9; previous revision: 1.8
done
Checking in browser/base/content/pageinfo/pageInfo.xul;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.xul,v  <--  pageInfo.xul
new revision: 1.11; previous revision: 1.10
done
Checking in browser/locales/en-US/chrome/browser/pageInfo.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageInfo.dtd,v  <--  pageInfo.dtd
new revision: 1.22; previous revision: 1.21
done
Checking in browser/locales/en-US/chrome/browser/pageInfo.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageInfo.properties,v  <--  pageInfo.properties
new revision: 1.11; previous revision: 1.10
done
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Firefox 3 Mx → Firefox 3 M10
Attached patch 386361-2.diffSplinter Review
This patch fixes seamonkey. In the future, can we try to keep them as close to in sync as possible?
Assignee: f.qu → db48x
Status: RESOLVED → ASSIGNED
Attachment #287994 - Flags: review?
Resolution: FIXED → ---
Attachment #287994 - Flags: review? → review?(kairo)
Comment on attachment 287994 [details] [diff] [review]
386361-2.diff

looks good from testing and comparing the code to the FF patch, r=me
Attachment #287994 - Flags: review?(kairo) → review+
Assignee: db48x → f.qu
Status: ASSIGNED → NEW
checked in.
Status: NEW → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
v. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112704 Minefield/3.0b2pre ID:2007112704
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.