386361 - Page Info no longer displays whether page is in quirks / standards compliance mode

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070629 Minefield/3.0a6pre

Gavin tells me that this got nuked in bug 339102. This is a very useful feature for web developers and needs to be added back.

Comment 1

[Dave Townsend [:mossop]]

Web developers can install the web developer toolbar. I think the bigger question is what use is this to regular users?

Personally I liked using it to point out that the websites they are seeing aren't using standards compliant rendering.

Comment 2

[Phil Ringnalda (:philor)]

Web developers can, indeed; however, it's been implicated in so many bugs that testers/triagers cannot. If only we knew of an extension that they all have installed anyway, that could bring it back...

Comment 3

[Dave Townsend [:mossop]]

See also bug 346500 that can be wontfixed if we don't fix this I think.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

We need to figure out what things in Page Info are important, generally speaking, but I believe understanding how we're rendering something should be displayed.

Comment 5

[Gérard Talbot]

Indeed, rendering mode is an important info for developers and users as we can point out that the webpage is not triggering standards compliant rendering mode.

Voting for this bug.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

What's "uiwanted" about this bug? Beltzner has already said that we should re-add it, and mconnor marked it blocking :)

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

It should be re-added. Discussion about whether or not the string could be made to be more user friendly is in bug 346500.

Comment 8

[Florian Quèze [:florian]]

Attachment: patch v1

Add it back like it was before 339102.

Note: this displays "Quirks mode" for standalone images, not sure we should do that. Maybe it would be better to hide the line in this case.

Comment 9

[Asaf Romano (gone)]

Comment on attachment 286080 [details] [diff] [review]
patch v1

r=mano

Comment 10

[Reed Loden [:reed]]

Checking in browser/base/content/pageinfo/pageInfo.js;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.9; previous revision: 1.8
done
Checking in browser/base/content/pageinfo/pageInfo.xul;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.xul,v  <--  pageInfo.xul
new revision: 1.11; previous revision: 1.10
done
Checking in browser/locales/en-US/chrome/browser/pageInfo.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageInfo.dtd,v  <--  pageInfo.dtd
new revision: 1.22; previous revision: 1.21
done
Checking in browser/locales/en-US/chrome/browser/pageInfo.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageInfo.properties,v  <--  pageInfo.properties
new revision: 1.11; previous revision: 1.10
done

Comment 11

[Daniel Brooks [:db48x]]

Attachment: 386361-2.diff

This patch fixes seamonkey. In the future, can we try to keep them as close to in sync as possible?

Comment 12

[Robert Kaiser]

Comment on attachment 287994 [details] [diff] [review]
386361-2.diff

looks good from testing and comparing the code to the FF patch, r=me

Comment 13

[Daniel Brooks [:db48x]]

checked in.

Comment 15

[Kevin Brosnan]

v. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112704 Minefield/3.0b2pre ID:2007112704