Closed Bug 386386 Opened 12 years ago Closed 12 years ago

Crash [@ nsIContent::NodeInfo] replacing document root with <xul:observes/>

Categories

(Core :: XUL, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: jruderman, Assigned: mats)

References

(Blocks 2 open bugs)

Details

(Keywords: crash, testcase, Whiteboard: null pointer dereference)

Crash Data

Attachments

(3 files)

Thread 0 Crashed:
0   nsCOMPtr<nsINodeInfo>::get_DerivedSafe() const + 9 (nsContentDLF.cpp:910)
1   nsCOMPtr<nsINodeInfo>::operator nsDerivedSafe<nsINodeInfo>*() const + 17 (nsContentDLF.cpp:841)
2   nsIContent::NodeInfo() const + 20 (nsIContent.h:210)
3   nsXULDocument::FindBroadcaster(nsIContent*, nsIDOMElement**, nsString&, nsString&, nsIDOMElement**) + 211 (nsXULDocument.cpp:4081)
4   nsXULDocument::CheckBroadcasterHookup(nsIContent*, int*, int*) + 190 (nsXULDocument.cpp:4162)
5   nsXULDocument::AddElementToDocumentPre(nsIContent*) + 202 (nsXULDocument.cpp:1619)
6   nsXULDocument::AddSubtreeToDocument(nsIContent*) + 72 (nsXULDocument.cpp:1684)
7   nsXULDocument::ContentInserted(nsIDocument*, nsIContent*, nsIContent*, int) + 97 (nsXULDocument.cpp:1024)
As I needed a testcase for SeaMonkey breakpad support, I produced the following crash report for this bug:
http://crash-stats.mozilla.com/report/index/f0de7c87-2da7-11dc-8b0c-001a4bd43ef6?date=2007-07-08-23
Assignee: nobody → mats.palmgren
Attached patch Patch rev. 1Splinter Review
Attachment #280559 - Flags: superreview?(bzbarsky)
Attachment #280559 - Flags: review?(Olli.Pettay)
OS: Mac OS X → All
Hardware: PC → All
Attachment #280559 - Flags: review?(Olli.Pettay) → review+
Comment on attachment 280559 [details] [diff] [review]
Patch rev. 1

Neil is a better reviewer for this than I am.
Attachment #280559 - Flags: superreview?(bzbarsky) → superreview?(neil)
Attachment #280559 - Flags: superreview?(neil) → superreview+
Attachment #280559 - Flags: approval1.9?
Comment on attachment 280559 [details] [diff] [review]
Patch rev. 1

a1.9=dbaron
Attachment #280559 - Flags: approval1.9? → approval1.9+
Mats, if you would, please land this ASAP. If you can't, I can land it for you.
Attached patch MochitestSplinter Review
mozilla/content/xul/document/src/nsXULDocument.cpp 	1.785 
mozilla/layout/xul/test/Makefile.in 	1.3
mozilla/layout/xul/test/test_bug386386.html 	1.1 

-> FIXED
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: null pointer dereference
Target Milestone: --- → mozilla1.9 M9
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
Crash Signature: [@ nsIContent::NodeInfo]
You need to log in before you can comment on or make changes to this bug.