386399 - History folder children often duplicated, resulting in bug-like behavior elsewhere

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Christine Yen]

History folders in the sidebar are displayed with unique children only - duplicate children are filtered out in the view. However, during copy/paste transactions (which will be enabled by the fix for Bug 378558), the node's duplicate children aren't filtered out, and 'collapse duplicate' code shouldn't be put in the main copy/paste code.

Comment 1

[(not reading, please use [e-mail] instead)]

when we do grouping by day or day/site, we currently have to get results as visits (and not unique uris).  otherwise, we would not get a visit in more than one container.  [for site, most visited, last visited, I think we can and should get result by uri, so we don't have to remove duplicates in the view).

but even for day or day/site grouping, we should be able to remove duplicates when grouping or when filtering (but see bug #386396) in GetQueryResults().

Either way, we should not do the collapsing of duplicates in the treeView.js (or christine's code for bug #378558)

thanks for logging this!

Comment 2

[Marco Bonardo [:mak]]

much of this changed in bug 385245, so this is invalid now