Closed Bug 386473 Opened 17 years ago Closed 8 years ago

XPCOMUtilify SearchService

Categories

(Firefox :: Search, defect, P5)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: rflint, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file, 1 obsolete file)

Bug 386473 - Change a few QueryInterface functions in nsSearchService.js to use XPCOMUtils.generateQI. Based on a patch originally by Ryan Flint.
58 bytes, text/x-review-board-request
florian
: review+
Details
Attached patch Patch (backed out) (obsolete) — — Splinter Review 
      No description provided.
Attachment #270465 - Flags: review?(gavin.sharp)
Blocks: 381189
No longer blocks: 385492
Attachment #270465 - Flags: review?(gavin.sharp) → review+
mozilla/browser/components/search/nsSearchService.js 	1.98
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
This caused a large increase in leaks on tinderbox.
Yikes, It certainly did - investigating...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I'm not going to be able to track this down tonight, so I've backed out for now.
Flags: in-testsuite-
Is this worth trying again with all the various leak fixes that have gone on the trunk in the last 4 months?
Comment on attachment 270465 [details] [diff] [review]
Patch (backed out)

Worth a shot :)

Drivers - this is essentially low-risk cleanup that's been done about a dozen times throughout the codebase within the last couple months with no negative effects so far.
Attachment #270465 - Flags: approval1.9?
Comment on attachment 270465 [details] [diff] [review]
Patch (backed out)

approved, if you can be sure to land when its quiet and check for leaks
Attachment #270465 - Flags: approval1.9? → approval1.9+
It appears this was checked in on 2007-11-23 18:27, then backed out due to Rlk regression:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1195871340.1195872187.2093.gz&fulltext=1
Whiteboard: [not needed for 1.9]
Attachment #270465 - Attachment description: Patch → Patch (backed out)
Priority: -- → P5
Whiteboard: [not needed for 1.9] → [fxsearch]
Rank: 59
The factory part of this got landed in bug 568691. The remaining part for changing the QIs just needs doing. As Ryan hasn't been active for a few years, stealing this.
Assignee: rflint → standard8
Attachment #270465 - Attachment is obsolete: true
Comment on attachment 270465 [details] [diff] [review]
Patch (backed out)

Dropping old r+ so that mozreview can hopefully work.
Attachment #270465 - Flags: review+
Comment on attachment 8807118 [details]
Bug 386473 - Change a few QueryInterface functions in nsSearchService.js to use XPCOMUtils.generateQI. Based on a patch originally by Ryan Flint.

https://reviewboard.mozilla.org/r/90050/#review90078
Attachment #8807118 - Flags: review?(florian) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa679b6eced2
Change a few QueryInterface functions in nsSearchService.js to use XPCOMUtils.generateQI. Based on a patch originally by Ryan Flint. r=florian
https://hg.mozilla.org/mozilla-central/rev/fa679b6eced2
Status: REOPENED → RESOLVED
Closed: 17 years ago → 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: