XPCOMUtilify SearchService

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Search
P5
normal
Rank:
59
RESOLVED FIXED
11 years ago
a year ago

People

(Reporter: rflint, Assigned: standard8)

Tracking

Trunk
Firefox 52
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 270465 [details] [diff] [review]
Patch (backed out)
Attachment #270465 - Flags: review?(gavin.sharp)
Blocks: 381189
No longer blocks: 385492
Attachment #270465 - Flags: review?(gavin.sharp) → review+
mozilla/browser/components/search/nsSearchService.js 	1.98 
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
This caused a large increase in leaks on tinderbox.
Yikes, It certainly did - investigating...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I'm not going to be able to track this down tonight, so I've backed out for now.
Flags: in-testsuite-
Is this worth trying again with all the various leak fixes that have gone on the trunk in the last 4 months?
Yes!
Comment on attachment 270465 [details] [diff] [review]
Patch (backed out)

Worth a shot :)

Drivers - this is essentially low-risk cleanup that's been done about a dozen times throughout the codebase within the last couple months with no negative effects so far.
Attachment #270465 - Flags: approval1.9?
Comment on attachment 270465 [details] [diff] [review]
Patch (backed out)

approved, if you can be sure to land when its quiet and check for leaks
Attachment #270465 - Flags: approval1.9? → approval1.9+

Comment 9

10 years ago
It appears this was checked in on 2007-11-23 18:27, then backed out due to Rlk regression:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1195871340.1195872187.2093.gz&fulltext=1
Whiteboard: [not needed for 1.9]
Attachment #270465 - Attachment description: Patch → Patch (backed out)
Priority: -- → P5
Whiteboard: [not needed for 1.9] → [fxsearch]

Updated

2 years ago
Rank: 59
(Assignee)

Comment 10

a year ago
The factory part of this got landed in bug 568691. The remaining part for changing the QIs just needs doing. As Ryan hasn't been active for a few years, stealing this.
Assignee: rflint → standard8
(Assignee)

Updated

a year ago
Attachment #270465 - Attachment is obsolete: true
(Assignee)

Comment 11

a year ago
Comment on attachment 270465 [details] [diff] [review]
Patch (backed out)

Dropping old r+ so that mozreview can hopefully work.
Attachment #270465 - Flags: review+
Comment hidden (mozreview-request)

Comment 13

a year ago
mozreview-review
Comment on attachment 8807118 [details]
Bug 386473 - Change a few QueryInterface functions in nsSearchService.js to use XPCOMUtils.generateQI. Based on a patch originally by Ryan Flint.

https://reviewboard.mozilla.org/r/90050/#review90078
Attachment #8807118 - Flags: review?(florian) → review+

Comment 14

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa679b6eced2
Change a few QueryInterface functions in nsSearchService.js to use XPCOMUtils.generateQI. Based on a patch originally by Ryan Flint. r=florian

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fa679b6eced2
Status: REOPENED → RESOLVED
Last Resolved: 11 years agoa year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.