386482 - Add a setter for richlistitem.searchLabel

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Simon Bünzli]

(to conform to expectations due to similar properties and to the foresightful documentation)

Comment 1

[Simon Bünzli]

Attachment: fix

Not sure whether a way to revert to the default value is really needed, but |item.searchLabel = null| seems nicer than |item.removeAttribute("searchlabel")| and more in line with |item.searchLabel = "find me"| and |item.searchLabel = ""|.

Comment 2

[Neil Deakin]

Comment on attachment 270478 [details] [diff] [review]
fix

>+            if (val !== null)
>+              this.setAttribute("searchlabel", val);

Just use if (val)

Comment 3

[Simon Bünzli]

Due to the the way the getter works, there are three different cases:

item.searchLabel = "text" // FAYT tries to match "text"
item.searchLabel = ""     // FAYT never selects this item
item.searchLabel = null   // FAYT tries to match item.label

Using |if (val)| instead of |if (val !== null)| would prevent the second case, i.e. excluding an item from FAYT by giving it an empty searchlabel.

Should you not want to allow the second case, the getter would have to be rewritten to |return this.getAttribute("searchlabel") || this.label;|.

Comment 4

[Shawn Wilsher :sdwilsh]

Checking in toolkit/content/widgets/richlistbox.xml;
new revision: 1.40; previous revision: 1.39