Closed Bug 386495 Opened 17 years ago Closed 17 years ago

Javascript is not disabled when designMode is on

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha8

People

(Reporter: martijn.martijn, Assigned: peterv)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files, 1 obsolete file)

v1
1.62 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Mochitest
2.19 KB, patch
martijn.martijn
: review+
Details | Diff | Splinter Review
Attached file testcase (obsolete) — 
See testcase, you should not get an alert after 500ms, and clicking on the button should not give an alert.
This regressed with bug 237964, I think.
Assignee: nobody → peterv
Attached patch v1 — — Splinter Review 
Doh.
Attachment #270614 - Flags: superreview?(jst)
Attachment #270614 - Flags: review?(jst)
Attachment #270614 - Flags: superreview?(jst)
Attachment #270614 - Flags: superreview+
Attachment #270614 - Flags: review?(jst)
Attachment #270614 - Flags: review+
Definitely need to Mochitest version of this testcase.
Flags: in-testsuite?
Attached patch Mochitest — — Splinter Review 

        Attachment #270491 -
        Attachment is obsolete: true

        Attachment #270741 -
        Flags: review?(martijn.martijn)

    
    

    
  
Fixed, but still need to checkin the Mochitest (waiting for Martijn's review).
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 270741 [details] [diff] [review]
Mochitest

Oops, sorry for the delay.

The test looks fine to me, but why are you using such large delay values, 500 and 1000?
I just tested with 50 and 100 and that seems to work just fine.

        Attachment #270741 -
        Flags: review?(martijn.martijn) → review+

    
  
Flags: in-testsuite? → in-testsuite+
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9beta1

    
    

    
  
Martijn: We *think* this test is causing us problems in bug#517130. Can you have a look? If yes, should we keep that separate bug, or just reopen this bug?

    
    

    
  
I don't know why the test is causing problems on Fennec. Afaict, it shouldn't, because the test seems sound to me.

    
    

    
  
It seems this wasn't fixed completely.  I filed bug 822213.

          You need to log in
          before you can comment on or make changes to this bug.