386536 - Add category manager helpers to XPCOMUtils

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Nickolay_Ponomarev]

Attachment: patch

It's common for an XPCOM component to get registered for various categories via the category manager. Currently you have to write a register hook which gets the category manager and uses it to register the component.

This patch lets the author add a simple declaration to the component's prototype, like this:
 _xpcom_categories: [{category: "some-category"}]
- and the XPCOMUtils' module takes care of registering the component for the specified categories. As an example, I converted fuel to use the helpers.

The patch is not quite tested, but passes the fuel auto-tests.

Comment 1

[Robert Sayre]

Comment on attachment 270529 [details] [diff] [review]
patch

r=sayrer for the xpcom changes, let's see what mfinkle thinks about the FUEL stuff. sorry for the delay.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 270529 [details] [diff] [review]
patch

## This patch has bitrotted a bit ##

>Index: browser/fuel/src/fuelApplication.js
>+Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
>+

This is already done

>+    // add Application as a global property for easy access
>+    { category: "JavaScript global property" }
>+  ],

We now use the new "JavaScript global privileged property" 

>   // for nsISupports
>   QueryInterface: function app_qi(aIID) {
>-    // add any other interfaces you support here

Obsolete change


Very nice addition to XPCOMUtils!

r=me with bitrot fixes

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: unbitrotted

Comment 4

[Nickolay_Ponomarev]

Ryan, thanks for creating an updated patch!

Comment 5

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/browser/fuel/src/fuelApplication.js 	1.18 	mozilla/js/src/xpconnect/loader/XPCOMUtils.jsm 	1.7