386556 - Add missing IDs in 'messenger-overlay-sidebar.xul'

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Sven Giermann]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: Lightning 0.5 (build 2007062404)

I'm going to write an extension to Lightning, that modifies the outfit of the sidebar.
I recognized, that some elements are missing identifiers, especially the TABS and TABPANELS in 'ltnTabpanelBox'.

Could you please include the attached proposals or introduce your own IDs for elements in 'ltnTabpanelBox'?

Reproducible: Always

Comment 1

[Sven Giermann]

Attachment: Patch to include missing IDs

Comment 2

[Simon Paquet [:sipaq]]

Comment on attachment 270550 [details] [diff] [review]
Patch to include missing IDs

Joey Minta is no longer doing reviews for Calendar stuff.

Comment 3

[Michael Büttner (no reviews TFN)]

Comment on attachment 270550 [details] [diff] [review]
Patch to include missing IDs

This looks as a valid request to me, r=mickey. In order to save you valuable time, I'd like to mention that most of the UI is currently restructured and the tabs you're assigning ids to are going to be removed in the near future. Bug #385900 will remove the tabs, moving the agenda and todo-list to a new pane. Nevertheless, I'll integrate those new ids and make sure that the new pane also provides hooks for themes.

Comment 4

[Michael Büttner (no reviews TFN)]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED