386610 - pyxpcom fails to build against python 2.5 (api changed)

Status: RESOLVED FIXED

Description

[Alexander Sack]

python 2.5 now makes use of Py_ssize_t which makes the build of pyxpcom fail on 64-bit architectures.

I will attach two patches:
 1. a patch that detects if Py_ssize_t is available in configure.in.
 2. a patch that typdefs Py_ssize_t as int in case that python api doesn't provide it; further the patch adds boundary checks because we cannot really deal with 64-bit sized buffers.

Comment 1

[Alexander Sack]

Created attachment 270602 [details] [diff] [review]
detect if Py_ssize_t is provided by python API (e.g. since 2.5)

Comment 2

[Alexander Sack]

Created attachment 270603 [details] [diff] [review]
fix build ... and fail if buffer size exceeds 32-bits

Comment 3

[Alexander Sack]

Comment on attachment 270603 [details] [diff] [review]
fix build ... and fail if buffer size exceeds 32-bits

mhammond, are you still active so you can review? this patch needs 

https://bugzilla.mozilla.org/attachment.cgi?id=270602

to work, but will allow pyxpcom to build build against python 2.4 as well as python 2.5

Comment 4

[Mark Hammond [:markh]]

Comment on attachment 270603 [details] [diff] [review]
fix build ... and fail if buffer size exceeds 32-bits

Sorry for the delay - I don't check bugmail as often as I should.

PEP 353 suggests using:

#if PY_VERSION_HEX < 0x02050000 && !defined(PY_SSIZE_T_MIN)

which would make the configure change unnecessary.  PY_SSIZE_T_MAX should also be defined.  Apart from that it looks good.

Comment 5

[Alexander Sack]

ok thanks for the feedback ... will update patch accordingly and rerequest review.

Comment 6

[Reed Loden [:reed] (use needinfo?)]

asac, how about an updated patch? :)

Comment 7

[Alexander Sack]

Created attachment 285276 [details] [diff] [review]
updated with comments

sorry for the the delay. Release time here atm :).

Comment 8

[Mark Hammond [:markh]]

Comment on attachment 285276 [details] [diff] [review]
updated with comments

looks good to me

Comment 9

[Alexander Sack]

not in the default firefox build. requesting landing.

Comment 10

[Reed Loden [:reed] (use needinfo?)]

Checking in extensions/python/xpcom/src/PyGInputStream.cpp;
/cvsroot/mozilla/extensions/python/xpcom/src/PyGInputStream.cpp,v  <--  PyGInputStream.cpp
new revision: 1.5; previous revision: 1.4
done
Checking in extensions/python/xpcom/src/PyIInputStream.cpp;
/cvsroot/mozilla/extensions/python/xpcom/src/PyIInputStream.cpp,v  <--  PyIInputStream.cpp
new revision: 1.7; previous revision: 1.6
done
Checking in extensions/python/xpcom/src/PyXPCOM.h;
/cvsroot/mozilla/extensions/python/xpcom/src/PyXPCOM.h,v  <--  PyXPCOM.h
new revision: 1.22; previous revision: 1.21
done