386670 - Restart button tooltip in add-ons manager should be changed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Michael Ventnor]

Currently the tooltip for the now-permanent restart button reads "Restart Minefield to finish the installation". But since the button is now made permanent, there doesn't need to be an installation, so the tooltip should be updated to reflect that and prevent confusion.

I suggest something like "Restart Minefield to apply add-on changes"

Comment 1

[Dão Gottwald [:dao]]

Attachment: Restart &brandShortName; to apply Add-on changes

Comment 2

[Michael Ventnor]

I heard that you'll need to change the entity name so that localizers are pinged. Then they'll know to change it too.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 270708 [details] [diff] [review]
Restart &brandShortName; to apply Add-on changes

I think Add-on is superfluous here.  Also, Michael's right, you need to change the ent name.

Comment 4

[Dão Gottwald [:dao]]

What do you suggest as a new entity?
cmd.restart.*?
cmd.restartApp2.*?
cmd.restartApp.tooltip2?

Comment 5

[Michael Ventnor]

(In reply to comment #4)
> What do you suggest as a new entity?

I personally prefer cmd.restartApp.tooltip2

Comment 6

[Dão Gottwald [:dao]]

Attachment: Restart &brandShortName; to apply changes

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 274134 [details] [diff] [review]
Restart &brandShortName; to apply changes

Great, but please change cmd.restartApp.tooltip2 to cmd.restartApp2.tooltip since the .label and .tooltip appendages are used by MozillaTranslator.

Just needs to be fixed before checkin, no more review needed.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch for checkin

renamed cmd.restartApp to cmd.restartApp2

Comment 9

[Michael Wu [:mwu]]

Checking in toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd,v  <--  extensions.dtd
new revision: 1.22; previous revision: 1.21
done
Checking in toolkit/mozapps/extensions/content/extensions.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xul,v  <--  extensions.xul
new revision: 1.58; previous revision: 1.57
done

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4632

in-litmus+

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007090604 Minefield/3.0a8pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007090604 Minefield/3.0a8pre

and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007090604 Minefield/3.0a8pre