386683 - Warnings in JS Console About empty langgroup in gfxFontStyle::gfxFontStyle

Status: RESOLVED DUPLICATE of bug 385516

(Core :: Graphics, defect)

Description

[Scott MacGregor]

Trunk build from 07/02.

I get a fair number of warnings dumped to my JS console in gfxFontStyle::gfxFontStyle complaining about the fact that aLangGroup is an empty string.

It looks like nsThebesDeviceContext::GetSystemFont intentionally passes in an empty string to the gfxFontStyle constructor.

Seems like that either shouldn't be a warning or we shouldn't pass in an empty string.

I'm happy to submit a patch if someone who knows the gfx thebes code tells me which they prefer.


Here's part of the stack trace:

 	gfxFontStyle::gfxFontStyle() Line 566	C++
	nsThebesDeviceContext::GetSystemFont() Line 413	C++
 	nsRuleNode::SetFont() Line 1945	C++
 	nsRuleNode::ComputeFontData() Line 2355	C++
 	nsRuleNode::WalkRuleTree() Line 73	C++
 	nsRuleNode::GetFontData() Line 1171	C++
 	nsRuleNode::GetStyleData() Line 73	C++
 	nsStyleContext::GetStyleData() Line 224	C++
 	nsRuleNode::WalkRuleTree() Line 1461	C++

 	nsRuleNode::GetStyleData()	C++
 	nsStyleContext::GetStyleData()	C++
 	nsRuleNode::WalkRuleTree()	C++
 	nsRuleNode::GetFontData()	C++