386821 - need better solution for firing delayed event against xul tree

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Evan Yan]

originate from bug 386161.

Currently we use the selected xul treeitem accessible instead of xul tree accessible, like in nsRootAccessible::HandleEventWithTarget() and nsAccEvent::GetAccessibleByNode() (after the patch of bug 386161 checked in).

If we want to fire delayed event against xul tree itself or unselected treeitem, there will be problem.

Comment 1

[Aaron Leventhal]

Evan, can you take this bug?

What is it blocking?

Comment 2

[Evan Yan]

It is not blocking anything for now.
Just to log a potential problem here, in case one day we have the requirement of firing event against xul tree itself or unselected treeitem.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

fix focus event firing, other events look good

Comment 4

[Trevor Saunders (:tbsaunde)]

This look good, but I have  still should look through the 40 or so places we create an event.

It seems fairly inconsistant that atk and mac both assert in FirePlatformEvent() that AccEvent->GetAccessible() returns a accessible, but GetAccessible(0 checks for its node being null instead of taking it as an invariant that it isn't null and getting the accessible for the node without checking the node to see if its null.

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #4)

> It seems fairly inconsistant that atk and mac both assert in
> FirePlatformEvent() that AccEvent->GetAccessible() returns a accessible, but
> GetAccessible(0 checks for its node being null instead of taking it as an
> invariant that it isn't null and getting the accessible for the node without
> checking the node to see if its null.

event code is little bit inconsistent and the logic is little bit wobbly. Ideally event should be always fired for not null accessible and keep weak accessible pointer rather than addrefed. All we have now is result of code reorgs by parts.

Comment 6

[Trevor Saunders (:tbsaunde)]

Comment on attachment 552314 [details] [diff] [review]
patch

SORRY IT TOOK SO LONG TO FINISH THIS UP.

Comment 7

[alexander :surkov (:asurkov)]

inbound - http://hg.mozilla.org/integration/mozilla-inbound/rev/f9379ad86c5d

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f9379ad86c5d