Closed Bug 386906 Opened 17 years ago Closed 16 years ago

remove xpfe chrome registry

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

Details

Attachments

(1 file)

Now that SeaMonkey uses toolkit and its better chrome registry, we should kill the old xpfe chromereg code from the Mozilla repository.
We should also remove this stuff:

http://lxr.mozilla.org/seamonkey/source/toolkit/toolkit-tiers.mk#180
180 ifdef MOZ_XUL_APP
181 tier_toolkit_dirs += chrome
182 else
183 ifdef MOZ_XUL
184 tier_toolkit_dirs += rdf/chrome
185 else
186 tier_toolkit_dirs += embedding/minimo/chromelite
187 endif
188 endif

http://lxr.mozilla.org/seamonkey/source/allmakefiles.sh#525
525 rdf/chrome/Makefile
526 rdf/chrome/public/Makefile
527 rdf/chrome/build/Makefile
528 rdf/chrome/src/Makefile
529 rdf/chrome/tools/Makefile
530 rdf/chrome/tools/chromereg/Makefile

Someone from embedding should check if this line is still needed:
http://lxr.mozilla.org/seamonkey/source/embedding/lite/Makefile.in#71
71 LOCAL_INCLUDES  = -I$(topsrcdir)/rdf/chrome/src

BTW, it looks like Camino still uses rdf/chrome:
http://lxr.mozilla.org/seamonkey/source/camino/Camino.xcodeproj/project.pbxproj#2842
2842                 F56F244602AC714601A967F3 /* libchrome.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; name = libchrome.a; path = ../rdf/chrome/build/libchrome.a; sourceTree = SOURCE_ROOT; };
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
This patch removes the old chromereg in rdf/chrome as well as its light version in minimo/chromelite which is the only remaining directory in the minimo dir.
I'll deal with embedding/lite in bug 451909 as it's |ifndef MOZ_XUL_APP| anyway.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #335393 - Flags: review?(benjamin)
Attachment #335393 - Flags: review?(benjamin) → review+
Thanks, checked in. we hopefully are down to one chrome registry in our tree :)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: