386920 - Text with "font-variant: small-caps" no longer wraps properly

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Matt Lemieux]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007070404 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007070404 Minefield/3.0a7pre

Text is not wrapping properly inside its div and instead extends on a single line.

Reproducible: Always

Steps to Reproduce:
1. Open current nightly in Minefield
2. Navigate to http://xkcd.com
3. Observe that text doesn't not wrap properly
Actual Results:  
Text appears as single line.

Expected Results:  
Text wraps inside div as previously.

Comment 1

[Matt Lemieux]

Confirmations from various Win platforms here:
http://forums.mozillazine.org/viewtopic.php?p=2953161#2953161

Comment 2

[philippe (part-time)]

It is due to the use of 'font-variant:small-caps'.

Comment 3

[philippe (part-time)]

Attachment: minimal testcase

Comment 4

[philippe (part-time)]

That regressed between 2007070320 and 2007070321 (Mac Builds)
--> bug 385423

Comment 5

[skierpage]

Slight clarification and simplification: just put 

<span style="font-variant: small-caps">a</span>

in a paragraph and it stops wrapping from the small caps *onwards* for the rest of the paragraph.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The glyph-copying process is wiping out the line-break data, which is not really a good idea. This doesn't usually matter because we're usually copying into new textruns, but the small-caps code copies glyphs into an existing textrun and expects the line-break data to be preserved.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in reftest.