The default bug view has changed. See this FAQ.

Get grippies on error console

RESOLVED FIXED in seamonkey2.0a1

Status

SeaMonkey
UI Design
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Trunk
seamonkey2.0a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
The SeaMonkey error console on trunk lacks grippies, but as we already have an overlay for them, those are quite easy to add, and I'll do that here.
(Assignee)

Comment 1

10 years ago
Created attachment 271044 [details] [diff] [review]
add grippies to error console toolbars

Here's the quite straight forward patch to do this :)
Attachment #271044 - Flags: superreview?(neil)
Attachment #271044 - Flags: review?(neil)

Comment 2

10 years ago
Comment on attachment 271044 [details] [diff] [review]
add grippies to error console toolbars

> 
> <?xul-overlay href="chrome://global/content/globalOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/tasksOverlay.xul"?>
> 
>+<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
>+
Nit: stylesheets before overlays

Now, this patch is OK, but in testing it I found two problems:
1. No tooltips on grippies
2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar tbalign="center"> and doesn't like having align="center" on toolbars.
Attachment #271044 - Flags: superreview?(neil)
Attachment #271044 - Flags: superreview+
Attachment #271044 - Flags: review?(neil)
Attachment #271044 - Flags: review+
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> Nit: stylesheets before overlays

corrected on checkin

> Now, this patch is OK, but in testing it I found two problems:
> 1. No tooltips on grippies

I only see them on collapsed grippies, but this seems to be the same as on a branch build .

> 2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar
> tbalign="center"> and doesn't like having align="center" on toolbars.

Oh, is this the weirdness I see in styling of the eval toolbar grippy?
(Assignee)

Comment 4

10 years ago
Sorry, forgot to mark FIXED. I checked this in - thanks for the fast review :)
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.