Closed Bug 386968 Opened 13 years ago Closed 13 years ago

Get grippies on error console

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: kairo, Assigned: kairo)

Details

Attachments

(1 file)

The SeaMonkey error console on trunk lacks grippies, but as we already have an overlay for them, those are quite easy to add, and I'll do that here.
Here's the quite straight forward patch to do this :)
Attachment #271044 - Flags: superreview?(neil)
Attachment #271044 - Flags: review?(neil)
Comment on attachment 271044 [details] [diff] [review]
add grippies to error console toolbars

> 
> <?xul-overlay href="chrome://global/content/globalOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/tasksOverlay.xul"?>
> 
>+<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
>+
Nit: stylesheets before overlays

Now, this patch is OK, but in testing it I found two problems:
1. No tooltips on grippies
2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar tbalign="center"> and doesn't like having align="center" on toolbars.
Attachment #271044 - Flags: superreview?(neil)
Attachment #271044 - Flags: superreview+
Attachment #271044 - Flags: review?(neil)
Attachment #271044 - Flags: review+
(In reply to comment #2)
> Nit: stylesheets before overlays

corrected on checkin

> Now, this patch is OK, but in testing it I found two problems:
> 1. No tooltips on grippies

I only see them on collapsed grippies, but this seems to be the same as on a branch build .

> 2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar
> tbalign="center"> and doesn't like having align="center" on toolbars.

Oh, is this the weirdness I see in styling of the eval toolbar grippy?
Sorry, forgot to mark FIXED. I checked this in - thanks for the fast review :)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.