386968 - Get grippies on error console

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

The SeaMonkey error console on trunk lacks grippies, but as we already have an overlay for them, those are quite easy to add, and I'll do that here.

Comment 1

[Robert Kaiser]

Attachment: add grippies to error console toolbars

Here's the quite straight forward patch to do this :)

Comment 2

[[e-mail]]

Comment on attachment 271044 [details] [diff] [review]
add grippies to error console toolbars

> 
> <?xul-overlay href="chrome://global/content/globalOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/tasksOverlay.xul"?>
> 
>+<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
>+
Nit: stylesheets before overlays

Now, this patch is OK, but in testing it I found two problems:
1. No tooltips on grippies
2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar tbalign="center"> and doesn't like having align="center" on toolbars.

Comment 3

[Robert Kaiser]

(In reply to comment #2)
> Nit: stylesheets before overlays

corrected on checkin

> Now, this patch is OK, but in testing it I found two problems:
> 1. No tooltips on grippies

I only see them on collapsed grippies, but this seems to be the same as on a branch build .

> 2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar
> tbalign="center"> and doesn't like having align="center" on toolbars.

Oh, is this the weirdness I see in styling of the eval toolbar grippy?

Comment 4

[Robert Kaiser]

Sorry, forgot to mark FIXED. I checked this in - thanks for the fast review :)