Last Comment Bug 386968 - Get grippies on error console
: Get grippies on error console
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
-- normal (vote)
: seamonkey2.0a1
Assigned To: Robert Kaiser
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-05 06:07 PDT by Robert Kaiser
Modified: 2008-07-31 04:24 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
add grippies to error console toolbars (2.28 KB, patch)
2007-07-05 06:11 PDT, Robert Kaiser
neil: review+
neil: superreview+
Details | Diff | Splinter Review

Description User image Robert Kaiser 2007-07-05 06:07:52 PDT
The SeaMonkey error console on trunk lacks grippies, but as we already have an overlay for them, those are quite easy to add, and I'll do that here.
Comment 1 User image Robert Kaiser 2007-07-05 06:11:45 PDT
Created attachment 271044 [details] [diff] [review]
add grippies to error console toolbars

Here's the quite straight forward patch to do this :)
Comment 2 User image neil@parkwaycc.co.uk 2007-07-05 06:35:18 PDT
Comment on attachment 271044 [details] [diff] [review]
add grippies to error console toolbars

> 
> <?xul-overlay href="chrome://global/content/globalOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?>
> <?xul-overlay href="chrome://communicator/content/tasksOverlay.xul"?>
> 
>+<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
>+
Nit: stylesheets before overlays

Now, this patch is OK, but in testing it I found two problems:
1. No tooltips on grippies
2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar tbalign="center"> and doesn't like having align="center" on toolbars.
Comment 3 User image Robert Kaiser 2007-07-05 06:44:14 PDT
(In reply to comment #2)
> Nit: stylesheets before overlays

corrected on checkin

> Now, this patch is OK, but in testing it I found two problems:
> 1. No tooltips on grippies

I only see them on collapsed grippies, but this seems to be the same as on a branch build .

> 2. Toolkit uses <toolbar align="center"> whereas XPFE uses <toolbar
> tbalign="center"> and doesn't like having align="center" on toolbars.

Oh, is this the weirdness I see in styling of the eval toolbar grippy?
Comment 4 User image Robert Kaiser 2007-07-05 06:44:52 PDT
Sorry, forgot to mark FIXED. I checked this in - thanks for the fast review :)

Note You need to log in before you can comment on or make changes to this bug.