The "Credits" button on Help -> About Dialog does not have an access key

RESOLVED FIXED in Firefox 3 alpha7

Status

()

Firefox
Keyboard Navigation
RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

(Blocks: 2 bugs, {access})

Trunk
Firefox 3 alpha7
access
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [in-litmus-bug-week])

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 271109 [details] [diff] [review]
The patch to add the access key handling both button title states

We need an access key for the "Credits" button in order to make it easy to access via the keyboard.  Since the button's label is toggled on activation, the access key should be valid in both states.

I'm posting a patch to fix this.
Attachment #271109 - Flags: review?(mano)
(Assignee)

Updated

11 years ago
Blocks: 204402
Comment on attachment 271109 [details] [diff] [review]
The patch to add the access key handling both button title states

r=mano.
Attachment #271109 - Flags: review?(mano) → review+
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]
Keywords: checkin-needed
Whiteboard: [checkin needed]
browser/base/content/aboutDialog.js 1.8
browser/base/content/aboutDialog.xul 1.28
browser/locales/en-US/chrome/browser/aboutDialog.dtd 1.9
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Keywords: verifyme
Flags: in-testsuite-
(Assignee)

Updated

9 years ago
Flags: in-litmus?
Keywords: verifyme
Litmus testcase added:
https://litmus.mozilla.org/show_test.cgi?id=12789
Flags: in-litmus? → in-litmus+
Whiteboard: [in-litmus-bug-week]
Anthony: we're removing the "Credits" button in bug 579547, so you'll have to revert that change :)
(In reply to comment #4)
> Anthony: we're removing the "Credits" button in bug 579547, so you'll have to
> revert that change :)

I'll do so when that bug is resolved.  Thanks for the heads up.
You need to log in before you can comment on or make changes to this bug.