387052 - OOM crash in softoken

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

pkcs11u.c contains the following code :

    object  = (SFTKObject*)PORT_ZAlloc(size);
    if (isSessionObject) {
	((SFTKSessionObject *)object)->hashSize = hashSize;
    }

object is not checked after the allocation. Some customers are seeing this crash in OOM situations.

Comment 1

[Julien Pierre]

Attachment: Fix OOM crash

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 271149 [details] [diff] [review]
Fix OOM crash

(Julien and I must have been working on this at the same time. He won the race. :)

sr=nelson
I'm surprised that Coverity didn't report this.

Comment 3

[Julien Pierre]

Nelson, Alexei, thanks for the reviews.

Checked in to the trunk :
Checking in pkcs11u.c;
/cvsroot/mozilla/security/nss/lib/softoken/pkcs11u.c,v  <--  pkcs11u.c
new revision: 1.75; previous revision: 1.74
done

And to NSS_3_11_BRANCH :
Checking in pkcs11u.c;
/cvsroot/mozilla/security/nss/lib/softoken/pkcs11u.c,v  <--  pkcs11u.c
new revision: 1.69.2.5; previous revision: 1.69.2.4
done