If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Rename some class names of the new Location bar

RESOLVED FIXED in Firefox 3 alpha7

Status

()

Firefox
Address Bar
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 3 alpha7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 271183 [details] [diff] [review]
patch

The current class names (textbox-presentation-*) are neither very clear nor generic enough, given that the formatted URL stuff could become a separate binding for use outside of a textbox. I'd like to address this before others start adopting their themes.

The patch also fixes a bug in the stylesheets (.textbox-presentation-slash doesn't exist anymore).
Attachment #271183 - Flags: review?(gavin.sharp)
(Assignee)

Comment 1

10 years ago
(In reply to comment #0)
> The patch also fixes a bug in the stylesheets (.textbox-presentation-slash
> doesn't exist anymore).

Btw, this fix is needed to make hideProtocols work properly.
Comment on attachment 271183 [details] [diff] [review]
patch

>Index: browser/themes/qinstripe/browser/browser.css

>+#urlbar[chromedir="rtl"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-subdomain ,
>+#urlbar[chromedir="ltr"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-port 

Shouldn't these both be "rtl"?

This also made me realize that we don't support RTL in pinstripe, so we should probably file a bug on removing the rtl rules you added there. Or you can do it here if you want.
Attachment #271183 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> (From update of attachment 271183 [details] [diff] [review])
> >Index: browser/themes/qinstripe/browser/browser.css
> 
> >+#urlbar[chromedir="rtl"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-subdomain ,
> >+#urlbar[chromedir="ltr"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-port 
> 
> Shouldn't these both be "rtl"?

Nope, subdomain needs text-align:right for ltr / left for rtl, port needs text-align:left for ltr / right for rtl.

> This also made me realize that we don't support RTL in pinstripe, so we should
> probably file a bug on removing the rtl rules you added there. Or you can do it
> here if you want.

I didn't know that. I'll update the patch.
(Assignee)

Comment 4

10 years ago
Created attachment 272025 [details] [diff] [review]
patch without RTL support for pinstripe (checked in)
Attachment #271183 - Attachment is obsolete: true
Attachment #272025 - Flags: review?(gavin.sharp)
Attachment #272025 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
Target Milestone: --- → Firefox 3 M7

Comment 5

10 years ago
Checked in "patch without RTL support for pinstripe". Clearing checkin-needed keyword.
Keywords: checkin-needed

Updated

10 years ago
Attachment #272025 - Attachment description: patch without RTL support for pinstripe → patch without RTL support for pinstripe (checked in)
(Assignee)

Comment 6

10 years ago
thanks
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.