Closed
Bug 387084
Opened 18 years ago
Closed 18 years ago
"View Page Info" is broken
Categories
(Firefox :: Page Info Window, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bugmozz, Assigned: mrbkap)
References
Details
(Keywords: regression, verified1.8.1.13, Whiteboard: regression from bug 384750)
Attachments
(1 file)
1.12 KB,
patch
|
jst
:
review+
jst
:
superreview+
dveditz
:
approval1.8.1.13+
asac
:
approval1.8.0.next?
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070513 Minefield/3.0a7pre ID:2007070513
[renge]
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1183665120&maxdate=1183666019
[error console]
Error: uncaught exception: [Exception... "Could not convert JavaScript argument arg 1 [nsIStringBundle.formatStringFromName]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: XStringBundle :: getFormattedString :: line 33" data: no]
Comment 1•18 years ago
|
||
-> bug 384750
can't set this block 384750 because it's a [sg] bug
Severity: normal → major
Updated•18 years ago
|
Component: Preferences → Page Info
Updated•18 years ago
|
Flags: blocking-firefox3?
Assignee | ||
Comment 2•18 years ago
|
||
With this patch, we can back out the fix for bug 387053 -- apparently, there are lots of places where we pass XPCNativeWrappers into code that wouldn't normally get them. In this case, we are in an XBL binding, whose filename is "XStringBundle". This hopefully won't hurt performance too much, since most implicit XPCNativeWrappers' uses should be in the files that we created them for.
Attachment #271192 -
Flags: superreview?(jst)
Attachment #271192 -
Flags: review?(jst)
Updated•18 years ago
|
QA Contact: preferences → page.info
Updated•18 years ago
|
Attachment #271192 -
Flags: superreview?(jst)
Attachment #271192 -
Flags: superreview+
Attachment #271192 -
Flags: review?(jst)
Attachment #271192 -
Flags: review+
Assignee | ||
Comment 4•18 years ago
|
||
Fix checked into trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 5•18 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070618 Minefield/3.0a7pre ID:2007070618
VERIFIED
Status: RESOLVED → VERIFIED
Updated•18 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Updated•17 years ago
|
Flags: blocking1.8.1.9+
Whiteboard: regression from bug 384750
Updated•17 years ago
|
Flags: wanted1.8.1.x+
Comment 6•17 years ago
|
||
Not taking bug 384750 in 1.8.1.12, don't need it's regression fix
Flags: blocking1.8.1.12+ → blocking1.8.1.13+
Assignee | ||
Comment 7•17 years ago
|
||
Comment on attachment 271192 [details] [diff] [review]
Proposed fix
This patch applies as-is.
Attachment #271192 -
Flags: approval1.8.1.13?
Comment 8•17 years ago
|
||
Comment on attachment 271192 [details] [diff] [review]
Proposed fix
approved for 1.8.1.13, a=dveditz for release-drivers
Attachment #271192 -
Flags: approval1.8.1.13? → approval1.8.1.13+
Comment 10•17 years ago
|
||
verified fixed for the 1.8 branch with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13 ID:2008031114
Keywords: fixed1.8.1.13 → verified1.8.1.13
Updated•17 years ago
|
Flags: blocking1.8.0.15+
Comment 11•17 years ago
|
||
Comment on attachment 271192 [details] [diff] [review]
Proposed fix
taking into distro patches.
Attachment #271192 -
Flags: approval1.8.0.15?
Comment 12•17 years ago
|
||
Comment on attachment 271192 [details] [diff] [review]
Proposed fix
a=caillon for 1.8.0.15
You need to log in
before you can comment on or make changes to this bug.
Description
•