387142 - regressed like bug 295223 (Bookmark menu collapses when hovering folder in level 1, quickly marking another folder in level 1, and then hovering folder in level 2 (subfolder of first folder).)

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The landing for bug 279703 is breaks the patch for bug 295223. The submenus are collapsed without the user's intention now. When the submenu items are hovered, they should cancel the collapsing timer.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070604 Minefield/3.0a7pre

Comment 1

[Ruediger Lahl]

(In reply to comment #0)

I can confirm that for my SM-Trunks on Vista since Build 2007070405

Comment 2

[Neil Deakin]

Attachment: work in progress

This patch cancels the timer properly. Still seeing an issue when a further layer of submenus is open so I'm going to investigate some more.

Comment 3

[Neil Deakin]

Attachment: cancel timer properly

This patch does two things when a menuitem is highlighted:
 - cancels the timer which would have closed up the popup the menu is in
 - rehighlights the menu in the parent

Comment 4

[[e-mail]]

Comment on attachment 271694 [details] [diff] [review]
cancel timer properly

>+  if (mCloseTimer &&
>+      NS_STATIC_CAST(nsIMenuParent *, mTimerMenu) == aMenuParent) {
static_cast<>() ;-) Though can't the compiler cast this itself?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 271694 [details] [diff] [review]
cancel timer properly

>Index: layout/xul/base/src/nsMenuFrame.cpp
>+    // sibling before moving onto a item within the submenu, causing the

"an item".

>Index: layout/xul/base/src/nsXULPopupManager.cpp
>+      NS_STATIC_CAST(nsIMenuParent *, mTimerMenu) == aMenuParent) {

You shouldn't need the cast here.

r+sr=bzbarsky with those changes.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> v.

Comment 7

[Dennis Jacobfeuerborn]

I was hoping that this would fix bug 341157 (which was marked as a dupe of bug 41766) but apparently it doesn't.

What I described there sounds pretty close to what is/was going on here (involuntary collapse of submenus) and makes the navigation of menus rather annoying.