387163 - Build ID screwed up in trunk (hour appears twice)

Status: VERIFIED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Carsten Book [:Tomcat]]

Current Build id for trunk is Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a7pre) Gecko/200707060404 Minefield/3.0a7pre

it should be YYYYMMDDHH and is YYYYMMDDHHHH ?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

For Mac:

Using about: in location bar:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707060404 Minefield/3.0a7pre

In the About dialog:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007070604 Minefield/3.0a7pre

This build started at 04:02.

Comment 2

[Adam Guthrie]

Need to kill this code: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/content/about.xhtml&rev=1.23&mark=90-93#85.

However, it still begs the question of whether we want the "full" build ID in the UA string.

Comment 3

[Zach Lipton [:zach]]

cc'ing some people who have had opinions before on how much of the build id to include in the UA string

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> Need to kill this code:
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/content/about.xhtml&rev=1.23&mark=90-93#85.

We added it intentionally, so I don't see why we'd want to kill it. This bug was about the actual UA we send over the wire, I thought - if it's not, then I say it's INVALID.

Comment 5

[Zach Lipton [:zach]]

My hack in about.xhtml assumes that the build id in the UA string is a shortened ID without the hour. My understanding is that currently, after bsmedberg's cleanup, the UA string now has the full 10-digit build id. Our options are thus: 

* Change the UA string back and have it use a shortened build id, or
* Remove the code in about.xhtml so that it shows just the UA, which includes the full, correct build id

Currently, about.xhtml has a 12-digit franken-buildid, which is definitely not right.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Ah, I see. Sorry, my fault for skimming the bug too quickly. I still think there are two separate issues: 1) whether or not we want the over-the-wire UA to use the longer date, and whether that was an intentional change (what I thought this bug was), and 2) fixing about.xhtml to better deal with the longer build ID should we decide to keep it.

Comment 7

[Daniel Veditz [:dveditz]]

The UA should not suddenly start showing a longer build-id.

Comment 8

[Benjamin Smedberg]

The change to the over-the-wire UA string were intentional, although I mean to file another bug to cover additional changes to the buildid which might include removing it from the UA string altogether.

Comment 9

[Serge Gautherie (:sgautherie)]

Confirming with SeaMonkey:

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a6pre) Gecko/2007070201 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/200707030505 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Comment 11

[Reed Loden [:reed]]

Attachment: patch - v1

Revert zach's change to about.xhtml (bug 345993) so that the build id in about: shows the correct 10-digit build id.

Comment 12

[Reed Loden [:reed]]

Checking in about.xhtml;
/cvsroot/mozilla/toolkit/content/about.xhtml,v  <--  about.xhtml
new revision: 1.24; previous revision: 1.23
done

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007081402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed, with SeaMonkey.

Comment 14

[Adam Guthrie]

I filed bug 392204 for the issue mentioned in comment 7.