[FIX]Nix direct same-origin checks in htmldocument, window, docshell

RESOLVED FIXED in mozilla1.9alpha8

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9alpha8
x86
Linux
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 271329 [details] [diff] [review]
Proposed patch

Use Equals() and Subsumes() instead.

Note that Subsumes() isn't as strict now as it was when the nsGlobalWindow timeout stuff was written.  It does the right check now, I think.
Attachment #271329 - Flags: superreview?(jst)
Attachment #271329 - Flags: review?(mrbkap)
(Assignee)

Comment 1

11 years ago
Though as I said in bug 370113, some of the nsDocument checks that call this code should perhaps be ownerDocument compares, not same-origin compares.

Updated

11 years ago
Attachment #271329 - Flags: superreview?(jst) → superreview+
Attachment #271329 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 2

11 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.