[FIX]Do Subsumes() check, not same-origin check, in Find code

RESOLVED FIXED in mozilla1.9alpha8

Status

()

RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9alpha8
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 271339 [details] [diff] [review]
Like so

In particular, stop using CheckSameOriginPrincipal.
Attachment #271339 - Flags: superreview?(jst)
Attachment #271339 - Flags: review?(jst)
Comment on attachment 271339 [details] [diff] [review]
Like so

-    // Do security check, to ensure that the frame we're searching
-    // is from the same origin as the frame from which the Find is
-    // being run.
+    // Do security check, to ensure that the frame we're searching is
+    // from is acccessible from the frame where the Find is being run.

Remove either "is accessible from" or "is from" there.
Attachment #271339 - Flags: superreview?(jst)
Attachment #271339 - Flags: superreview+
Attachment #271339 - Flags: review?(jst)
Attachment #271339 - Flags: review+
Removed "from is" to get the text I wanted.  Checked in.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey

Updated

9 years ago
Component: Search → Find Toolbar
Product: SeaMonkey → Toolkit
QA Contact: search → fast.find
You need to log in before you can comment on or make changes to this bug.