Closed
Bug 387220
Opened 17 years ago
Closed 17 years ago
[FIX]Do Subsumes() check, not same-origin check, in Find code
Categories
(Toolkit :: Find Toolbar, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.99 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
In particular, stop using CheckSameOriginPrincipal.
Attachment #271339 -
Flags: superreview?(jst)
Attachment #271339 -
Flags: review?(jst)
Comment 1•17 years ago
|
||
Comment on attachment 271339 [details] [diff] [review] Like so - // Do security check, to ensure that the frame we're searching - // is from the same origin as the frame from which the Find is - // being run. + // Do security check, to ensure that the frame we're searching is + // from is acccessible from the frame where the Find is being run. Remove either "is accessible from" or "is from" there.
Attachment #271339 -
Flags: superreview?(jst)
Attachment #271339 -
Flags: superreview+
Attachment #271339 -
Flags: review?(jst)
Attachment #271339 -
Flags: review+
Assignee | ||
Comment 2•17 years ago
|
||
Removed "from is" to get the text I wanted. Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → SeaMonkey
Updated•16 years ago
|
Component: Search → Find Toolbar
Product: SeaMonkey → Toolkit
QA Contact: search → fast.find
You need to log in
before you can comment on or make changes to this bug.
Description
•